Conversation
germanurrus
approved these changes
Sep 14, 2022
Contributor
germanurrus
left a comment
germanurrus
left a comment
There was a problem hiding this comment.
Tested locally and works fine
germanurrus
reviewed
Sep 14, 2022
Comment on lines
-362
to
-365
| propThreshold, err := strconv.ParseFloat(*payload.Proposal_threshold, 64) | ||
| if err != nil { | ||
| respondWithError(w, http.StatusBadRequest, "Error Converting Proposal Threshold to Float.") | ||
| } |
Contributor
There was a problem hiding this comment.
maybe we can keep this check
Collaborator
Contributor
Author
|
Here's the original ticket https://linear.app/dappercollectives/issue/CAS-414. @jbluks yeah it was being set as 0 before if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
•Removes controller level logic which returned an error if proposal threshold was set to 0
Notes
This is a quick fix to allow for community creation when
onlyAuthorsToSubmitProposalsis true, as the old code would make the backend throw an error here.Proper fix is, to write logic at the helper level that first:
checks if
onlyAuthorsToSubmitProposalsistrue.If yes, ensure that
proposalThreshold >= 1