Skip to content

CAS-108 - validate contract address during community creation#83

Merged
dbslone merged 7 commits intomainfrom
cas-108
Jul 7, 2022
Merged

CAS-108 - validate contract address during community creation#83
dbslone merged 7 commits intomainfrom
cas-108

Conversation

@germanurrus
Copy link
Copy Markdown
Contributor

@germanurrus germanurrus commented Jun 28, 2022

Depends on #62
Added validation for flow addresses, when creating a community it will show an error modal if any of the addresses used is not a valid flow addr. Maybe wording and some style will need to be added:

Screen Shot 2022-07-04 at 19 38 05

@germanurrus germanurrus marked this pull request as draft June 28, 2022 14:44
setTimeout(() => {
resolve(true);
}, milliSeconds);
});
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not used anywhere in the production code, but it's used when trying to create a delay on loading states.

'Contract Address': [contractAddress],
'Admin List': listAddrAdmins.map((e) => e.addr),
'Author List': listAddrAuthors.map((e) => e.addr),
Strategies: strategies,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strategies will be added on #62, adding them here to update Pr after #62 is merged

@germanurrus germanurrus self-assigned this Jul 4, 2022
@germanurrus germanurrus marked this pull request as ready for review July 4, 2022 22:58
@germanurrus germanurrus changed the title fix(frontend): validate contract address during community creation fix(frontend): cas-108 - validate contract address during community creation Jul 6, 2022
@germanurrus germanurrus changed the title fix(frontend): cas-108 - validate contract address during community creation CAS-108 - validate contract address during community creation Jul 6, 2022
# Conflicts:
#	frontend/packages/client/src/utils.js
@dbslone dbslone merged commit 3017d2e into main Jul 7, 2022
@dbslone dbslone deleted the cas-108 branch July 7, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants