Skip to content

CAS-169 - update fields validation on community creation#94

Merged
dbslone merged 5 commits intomainfrom
cas-169
Jul 7, 2022
Merged

CAS-169 - update fields validation on community creation#94
dbslone merged 5 commits intomainfrom
cas-169

Conversation

@germanurrus
Copy link
Copy Markdown
Contributor

@germanurrus germanurrus commented Jul 1, 2022

Update on community fields:
community name => required
community Description => not required
logo => not required, defaults to react-blockies
community Terms => not required
category => required

logo: 'https://i.imgur.com/RMKXPCw.png',
name: 'Flow',
description:
"Flow's decentralized governance and node operations community.",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use the logo from flow anymore as default

// check for logo upload
// admins can edit later the image
if (logo.file) {
if (logo?.file) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check when creating community if logo was added or not

termsUrl?.length > 0 && urlPatternValidation(termsUrl),
termsUrl?.length > 0 ? urlPatternValidation(termsUrl) : true,
category: (cat) => cat?.length > 0,
};
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the important changes are here

scale={9.6}
className="rounded-sm"
/>
)}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-07-01 at 17 53 54

scale={9.6}
className="blockies"
/>
)}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-07-01 at 17 53 48

@germanurrus germanurrus self-assigned this Jul 1, 2022
@germanurrus germanurrus requested a review from sarahy-Dapper July 4, 2022 17:13
@germanurrus germanurrus changed the title fix(frontend): update fields validation on community creation fix(frontend): cas-169 - update fields validation on community creation Jul 6, 2022
@germanurrus germanurrus changed the title fix(frontend): cas-169 - update fields validation on community creation CAS-169 - update fields validation on community creation Jul 6, 2022
@dbslone dbslone merged commit f1fcb66 into main Jul 7, 2022
@dbslone dbslone deleted the cas-169 branch July 7, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants