CAS-154 - add My Communities section to homepage by germanurrus · Pull Request #97 · DapperCollectives/CAST

germanurrus · 2022-07-05T14:46:24Z

Home page updates:

Added react-query
Remove redux dependencies not used
Moved some dependencies to dev dependencies

There's only one issue that will be addressed in another PR:

User clicks on join in a community in the home page from the feature communities section
If the "My Communities" section was not visible it should appear with the community the user has just joined. Same if the user leaves the community and that was the only one, the "My Communities" section should fade out

germanurrus · 2022-07-05T18:35:37Z

 $body-background-color: white
 $primary: $yellow
+$spacing-values: ("0": 0, "1": 0.25rem, "2": 0.5rem, "3": 0.75rem, "4": 1rem, "5": 1.5rem, "6": 3rem, "7": 4.5rem,"8": 6rem, "9": 9rem, "auto": auto) !default



This will enable us do use classNames with *-7, *-8 or *-9 instead of using the style prop of the component. Bulma comes with *-6 as max. https://bulma.io/documentation/helpers/spacing-helpers/

germanurrus · 2022-07-06T15:19:58Z

-    "redux": "^4.1.0",
-    "redux-persist": "^6.0.0",
-    "redux-persist-cookie-storage": "^1.0.0",
-    "redux-thunk": "^2.3.0",
-    "sass": "^1.49.8",
-    "string-strip-html": "8.3.0",
-    "prettier": "^2.7.1",
-    "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-prettier": "^4.0.0"


"react-redux": "^7.2.4", => removed "redux": "^4.1.0", => removed "redux-persist": "^6.0.0", => removed "redux-persist-cookie-storage": "^1.0.0", => removed "redux-thunk": "^2.3.0", => removed "sass": "^1.49.8", => moved to dev dependencies, only used at build time "prettier": "^2.7.1", => moved to dev dependencies "eslint-config-prettier": "^8.5.0" => moved to dev dependencies https://github.com/prettier/eslint-config-prettier#installation "eslint-plugin-prettier": "^4.0.0" => moved to dev dependencies https://github.com/prettier/eslint-plugin-prettier#installation

@germanurrus prettier and the eslint config have to be here otherwise the staging build breaks because of how monorepos work

added deps back and left out redux

germanurrus · 2022-07-06T15:31:37Z

+const queryClient = new QueryClient({
+  defaultOptions: {
+    queries: {
+      refetchOnWindowFocus: process.env.NODE_ENV !== 'development',


the default for this configuration is true seems to me too hard and resource consuming to use it on dev mode reloading every we switch seems: visual studio code <=> browser.
On prod or staging it's on with this code. Looks like a nice feature to keep the page updated, any suggestions?

I think we can keep the refetch on development as well. Our local machines are more powerful than staging/prod and unless new data is returned then no additional page renders occur.

dbslone · 2022-07-07T22:12:54Z

-    "redux": "^4.1.0",
-    "redux-persist": "^6.0.0",
-    "redux-persist-cookie-storage": "^1.0.0",
-    "redux-thunk": "^2.3.0",
-    "sass": "^1.49.8",
-    "string-strip-html": "8.3.0",
-    "prettier": "^2.7.1",
-    "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-prettier": "^4.0.0"


@germanurrus prettier and the eslint config have to be here otherwise the staging build breaks because of how monorepos work

dbslone · 2022-07-07T22:37:02Z

+    data:
+      data?.pages?.reduce((prev, current) => [...prev, ...current.data], []) ??
+      [],


it's possible for the API to return null on communities-for-homepage endpoint. To prevent errors maybe we should do something like:

data: data?.pages?.reduce((prev, current) => { return current.data ? [...prev, ...current.data] : prev; }, []),

dbslone · 2022-07-07T22:41:52Z

+const queryClient = new QueryClient({
+  defaultOptions: {
+    queries: {
+      refetchOnWindowFocus: process.env.NODE_ENV !== 'development',


I think we can keep the refetch on development as well. Our local machines are more powerful than staging/prod and unless new data is returned then no additional page renders occur.

dbslone · 2022-07-07T22:57:53Z

@germanurrus I'm unable to create a community when I visit /community/create the screen hangs on the loading screen

germanurrus · 2022-07-08T17:06:01Z

+import { QueryClient, QueryClientProvider } from 'react-query';
+
+// create react-query client
+const queryClient = new QueryClient();


default comes with refetchOnWindowFocus: true,

jbluks

LGTM

germanurrus added 3 commits July 5, 2022 11:44

add pagination

915e534

create hook for features communities

996d7ef

load featured communities

91ec893

germanurrus self-assigned this Jul 5, 2022

germanurrus added 2 commits July 5, 2022 14:10

add more space values

2c18e1b

update home page

636cfe2

germanurrus commented Jul 5, 2022

View reviewed changes

germanurrus added 8 commits July 5, 2022 16:52

Merge branch 'main' into cas-154

89603a6

update to load user communities

c35d2b0

update packages and install react-query

ec5a328

add react-query configuration

ea93097

update hook

dfd4ac4

update home page

6885b9f

fix error handler url param

794a766

Merge branch 'main' into cas-154

7bd793c

germanurrus commented Jul 6, 2022

View reviewed changes

add node env

c278549

germanurrus commented Jul 6, 2022

View reviewed changes

germanurrus requested review from CJamesKeller and dbslone July 6, 2022 15:37

germanurrus marked this pull request as ready for review July 6, 2022 15:37

germanurrus changed the title ~~feat(frontend): add My Communities section to homepage~~ cas-154 - add My Communities section to homepage Jul 6, 2022

germanurrus changed the title ~~cas-154 - add My Communities section to homepage~~ CAS-154 - add My Communities section to homepage Jul 6, 2022

germanurrus mentioned this pull request Jul 7, 2022

CAS-174 - update my communities section after joining a community #108

Merged

germanurrus requested a review from jbluks July 7, 2022 21:16

dbslone suggested changes Jul 7, 2022

View reviewed changes

germanurrus added 3 commits July 7, 2022 20:11

fix initial loading

02689e8

Merge branch 'main' into cas-154

babafc9

add deps back

381d5e6

germanurrus added 4 commits July 8, 2022 14:02

update config

fced25c

check for null on data prop

a521066

Merge branch 'main' into cas-154

09c7109

remove config leaving defaul

d3ac4fe

germanurrus commented Jul 8, 2022

View reviewed changes

jbluks approved these changes Jul 8, 2022

View reviewed changes

remove dups from array

cdeff3a

dbslone approved these changes Jul 8, 2022

View reviewed changes

Merge branch 'main' into cas-154

4dcec06

dbslone merged commit 8c43255 into main Jul 8, 2022

dbslone deleted the cas-154 branch July 8, 2022 22:10

Conversation

germanurrus commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

germanurrus Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dbslone commented Jul 7, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbluks left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

germanurrus commented Jul 5, 2022 •

edited

Loading

germanurrus Jul 5, 2022 •

edited

Loading