remove inherited stuff from pom, improve shading, fix mvn warnings#49
Merged
DarkEyeDragon merged 1 commit intoDarkEyeDragon:devfrom Oct 1, 2020
Trigary:mvn-changes
Merged
remove inherited stuff from pom, improve shading, fix mvn warnings#49DarkEyeDragon merged 1 commit intoDarkEyeDragon:devfrom Trigary:mvn-changes
DarkEyeDragon merged 1 commit intoDarkEyeDragon:devfrom
Trigary:mvn-changes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java 8 is actually called 1.8. Yes, they are named just "11" and stuff like that in later versions, but those are later versions.
Stuff gets inherited from the parent pom, so I removed some declarations.
Shading excludes were kind of broken. I turned on minification and excluded an annotation library, as per the suggestion of Kyori devs.
I changed the ${...] placeholders and migrated away from LATEST versions in order to get rid of the Maven warnings.