Skip to content

x#96

Merged
DarkModder33 merged 5 commits intosupabase-api-wirefrom
main
Mar 17, 2026
Merged

x#96
DarkModder33 merged 5 commits intosupabase-api-wirefrom
main

Conversation

@DarkModder33
Copy link
Copy Markdown
Owner

@DarkModder33 DarkModder33 commented Mar 17, 2026

x

Summary by Sourcery

Add automated Qodana static code analysis to the repository.

Build:

  • Add Qodana configuration file specifying the JVM linter, recommended profile, and dependency license checks.

CI:

  • Introduce a Qodana GitHub Actions workflow to run code quality checks on main and release branches, as well as on pushes and pull requests.

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Mar 17, 2026

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
28841237 Triggered Hugging Face user access token f002af9 main/.env.production View secret
27877826 Triggered Generic High Entropy Secret f002af9 main/.env.production View secret
27862575 Triggered Generic High Entropy Secret f002af9 main/.env.production View secret
28841250 Triggered OpenAI Admin API Key f002af9 main/.env.production View secret
28841233 Triggered Generic High Entropy Secret f002af9 main/.env.production View secret
27877825 Triggered Generic High Entropy Secret f002af9 main/.env.production View secret
28841238 Triggered Groq API Key f002af9 main/.env.production View secret
28841237 Triggered Hugging Face user access token f002af9 main/.env.production View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 17, 2026

Reviewer's Guide

Adds JetBrains Qodana static analysis to the project via a new GitHub Actions workflow and Qodana configuration file.

Flow diagram for Qodana code quality workflow execution

flowchart TD
  A["Event occurs"] --> B{Event type}

  B -->|push to main| C["Run Qodana workflow"]
  B -->|push to releases/*| C
  B -->|pull_request opened/synced| C
  B -->|workflow_dispatch| C
  B -->|other events| Z["Do not run Qodana"]

  C --> D["Start job qodana on ubuntu-latest"]
  D --> E["Set permissions:
contents, pull-requests, checks: write"]
  E --> F["Checkout code
actions/checkout@v3
ref=pull_request.head.sha
fetch-depth=0"]
  F --> G["Run JetBrains/qodana-action@v2025.3
with pr-mode=false"]
  G --> H["Use env:
QODANA_TOKEN from secrets
QODANA_ENDPOINT=https://qodana.cloud"]
  H --> I["Qodana analyzes codebase"]
  I --> J["Upload results to Qodana Cloud"]
  I --> K["Publish GitHub checks / PR annotations"]
Loading

File-Level Changes

Change Details Files
Introduce a Qodana GitHub Actions workflow to run static analysis on key Git events.
  • Create a Qodana workflow triggered on workflow_dispatch, pull_request, and pushes to main and release branches
  • Configure permissions for contents, pull-requests, and checks to allow Qodana to report results
  • Check out the pull request’s head SHA with full history to support accurate analysis
  • Run the JetBrains Qodana GitHub Action with pr-mode disabled and cloud endpoint and token supplied via secrets
.github/workflows/qodana_code_quality.yml
Add a Qodana configuration file specifying linter image and rules profile.
  • Set Qodana configuration version and use the jetbrains/qodana-jvm:2025.3 linter image
  • Use the qodana.recommended profile and explicitly include the CheckDependencyLicenses inspection
  • Document that sensitive information must not be stored in the configuration because it appears in reports
qodana.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
main Error Error Mar 31, 2026 1:40am
vallcallya Error Error Mar 31, 2026 1:40am

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9dfd9e0b-1056-4faa-a632-332eb3991fd8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch main
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use your project's `biome` configuration to improve the quality of JS/TS/CSS/JSON code reviews.

Add a configuration file to your project to customize how CodeRabbit runs biome.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 17, 2026

Deployment failed with the following error:

The `vercel.json` schema validation failed with the following message: should NOT have additional property `rootDirectory`

Learn More: https://vercel.com/docs/concepts/projects/project-configuration

@DarkModder33 DarkModder33 merged commit e3c6760 into supabase-api-wire Mar 17, 2026
2 of 23 checks passed
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 3 issues, and left some high level feedback:

  • For better supply-chain security, consider pinning actions/checkout and JetBrains/qodana-action to specific commit SHAs instead of version tags.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- For better supply-chain security, consider pinning `actions/checkout` and `JetBrains/qodana-action` to specific commit SHAs instead of version tags.

## Individual Comments

### Comment 1
<location path=".github/workflows/qodana_code_quality.yml" line_range="18-21" />
<code_context>
+      pull-requests: write
+      checks: write
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}  # to check out the actual pull request commit, not the merge commit
+          fetch-depth: 0  # a full history is required for pull request analysis
+      - name: 'Qodana Scan'
+        uses: JetBrains/qodana-action@v2025.3
</code_context>
<issue_to_address>
**issue:** Using `github.event.pull_request.head.sha` will fail on `push` and `workflow_dispatch` events where `pull_request` is undefined.

This expression is only defined for `pull_request` events; for `push` and `workflow_dispatch` it will be empty and likely break the job. You can either restrict this to PRs with `if: github.event_name == 'pull_request'` on the step, or fall back to the default SHA with something like `${{ github.event.pull_request.head.sha || github.sha }}` so all triggers work.
</issue_to_address>

### Comment 2
<location path=".github/workflows/qodana_code_quality.yml" line_range="11-16" />
<code_context>
+jobs:
+  qodana:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      pull-requests: write
+      checks: write
+    steps:
+      - uses: actions/checkout@v3
</code_context>
<issue_to_address>
**🚨 suggestion (security):** Workflow permissions are broader than necessary for a read-only analysis job.

These permissions let the job modify repo contents and PRs. If Qodana doesn’t need to push commits or edit PR descriptions, consider reducing to `contents: read` plus only the minimal `pull-requests`/`checks` permissions required by its integration. This limits impact if the workflow or an action is compromised.

```suggestion
  qodana:
    runs-on: ubuntu-latest
    permissions:
      contents: read
      pull-requests: read
      checks: write
```
</issue_to_address>

### Comment 3
<location path=".github/workflows/qodana_code_quality.yml" line_range="22-19" />
<code_context>
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}  # to check out the actual pull request commit, not the merge commit
+          fetch-depth: 0  # a full history is required for pull request analysis
+      - name: 'Qodana Scan'
+        uses: JetBrains/qodana-action@v2025.3
+        with:
+          pr-mode: false
+        env:
</code_context>
<issue_to_address>
**question:** Disabling `pr-mode` may forgo PR-specific feedback features that Qodana provides.

Since this workflow runs on `pull_request` with the PR head and full history (i.e., a PR analysis setup), consider enabling `pr-mode` (or relying on the default) so Qodana can add line-level annotations/comments on changed code instead of only producing a general report.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +18 to +21
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }} # to check out the actual pull request commit, not the merge commit
fetch-depth: 0 # a full history is required for pull request analysis
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Using github.event.pull_request.head.sha will fail on push and workflow_dispatch events where pull_request is undefined.

This expression is only defined for pull_request events; for push and workflow_dispatch it will be empty and likely break the job. You can either restrict this to PRs with if: github.event_name == 'pull_request' on the step, or fall back to the default SHA with something like ${{ github.event.pull_request.head.sha || github.sha }} so all triggers work.

Comment on lines +11 to +16
qodana:
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
checks: write
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Workflow permissions are broader than necessary for a read-only analysis job.

These permissions let the job modify repo contents and PRs. If Qodana doesn’t need to push commits or edit PR descriptions, consider reducing to contents: read plus only the minimal pull-requests/checks permissions required by its integration. This limits impact if the workflow or an action is compromised.

Suggested change
qodana:
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
checks: write
qodana:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: read
checks: write

@DarkModder33
Copy link
Copy Markdown
Owner Author

n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants