Adding Czech, Polish, and Ukrainian languages#1063
Conversation
## About The Pull Request Adds Czech, Polish, and Ukrainian language definitions. Also includes the new language files in tgstation.dme and updates the language icon DMI. ## Why It's Good For The Game Expands the choices of languages for Eastern European cultures, including their linguistic similarities/partial mutual intelligibility. ## Changelog Changes: - Added /language/ukrainian - Added /language/polish - Added /language/czech - Added each language to tgstation.dme - Added chat language icon states for Ukrainian, Polish, and Czech - Set each language to unrestricted so they appear as normal language options - Added mutual understanding values between Ukrainian, Polish, Czech, Russian, German, and Common where appropriate :cl: add: adds czech, polish, and ukrainian as languages /:cl: Testing: - Compiled successfully with 0 errors and 0 warnings - Tested in-game locally - Confirmed the languages appear in the language menu - Confirmed the speech keys work: - ,U for Ukrainian - ,P for Polish - ,C for Czech - Confirmed the language icons display in chat - Confirmed partial intelligibility works through the language menu and when spoken
FalloutFalcon
left a comment
FalloutFalcon
left a comment
There was a problem hiding this comment.
Seems fine. I talked with a few linguistics adjacent for the mutual understanding numbers on most of the rest of the langauges. adamproject hotel_moonstone if you want to see if they know much about this set.
I based the mutual intelligibility values on the percentage of common vocabulary between each language. I think at some point I may want to amend the rest of the languages too, as I think there's some overlap that was missed in the original module. People tend to understand more of foreign languages than we think, particularly within language family's (Indo-European in particular). |
|
Your Fix/Feature pull request is currently below zero (-3). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score. |
3 participants
About The Pull Request
Adds Czech, Polish, and Ukrainian language options in the dark pack language module.
Also includes the new language files in tgstation.dme and updates the language icon DMI.
Why It's Good For The Game
Expands the choices of languages for Eastern European cultures, including their linguistic similarities/partial mutual intelligibility.
Changelog
Changes:
🆑
add: adds czech, polish, and ukrainian as languages
/:cl:
Testing: