Various guestbook fixes#612
Conversation
|
fixes #484 tho fera rework does as well lol. |
## About The Pull Request ## Why It's Good For The Game ## Changelog :cl: /:cl:
* Update city_outsides.dm * Create SanFrancisco.dmm * Create sanfrancisco.json * AAA * Update SanFrancisco.dmm * Update SanFrancisco.dmm * grass fixes + apartment door fixes * sf is outdoors so rain now works on all z levels outside * changes some npc beacons to prevent blob formations and places some cops around the map in places other than the police station * fixes underwater fountains, trim issues, window issues, lighting issues, and changes the water in the lake to not be deep instantly, but have some shallow then deep * fixes depot using all interior areas, adds a tunnel area to block rain from the pacific heights tunnel * hospital elevator button * fixes interior rain at under-bridge shop * more shallow water by coasts * lighting in the warrens, graveyard gate gap bandaid fix * more grass fixes and adding placeholder landmarks for supply jobs pending whatever we do with supply/axegang * Update decor.dm * Update is_helpers.dm * Revert "Update is_helpers.dm" This reverts commit 18ce9a986b6c27fd2f1f398d230fe271847c7db6. * Update trash.dm * awaw * Revert "awaw" This reverts commit 14df78bb4d0bf7a1d02bf05e5380f1d0be215ac4. * Update jobs.dm * Update structure.dm * never should have come here * Update decor.dm * fixes some decal mishaps * Update SanFrancisco.dmm * a * umbra * fix checks related to umbra * g * pending * puts them back * awawa * Update __vtm.dm --------- Co-authored-by: Marshmellow105 <118340622+Marshmellow105@users.noreply.github.com>
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
FalloutFalcon
left a comment
FalloutFalcon
left a comment
There was a problem hiding this comment.
Why is this pr trying to move guestbook/generic names down to the living level when anything outside of humans cant be expected to have a unique name to start.
* decal * dark inner corner * decal sin fixing, finds the two decals that crash your sdmm and removes them * the last of the /obj/effect/turf_decal/siding sin fixes I think * railing wood siding fixes for docks and gio mansion * cat to stray spawner * sproingus was crashing my game so I made them all subtypes then added more stray animals to the park * wood sidings we have * remove dirt sidings as grass does the job now in most places and add carpet decal colours * carpet decal subtypening * rough wood decals * more wood rail fixes, removes depricated matrixes * replaces the old method of underground wrapping (matrixes in a 1 deep layer) with rock filling akin to westfieldmall * railing shit * forgot these * whatever
real_name is a variable on the base mob level, so anything can have a unique name to start. One use case is fera wolves. |
fera wolves are humans lmao. But what im saying is if multiple mobs have the same real_name (most non-humans) then if you try and guestbook one it guestbooks all of them. |
the system only works if that mob has a mind. also whAT DO YOU MEAN FERA WOLVES ARE HUMANS.................. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
This reverts commit d885ba8.
…Final-Nights-Rebase into guestbook-fixes
5 participants
About The Pull Request
Fixed names not updating when they should be.
Why It's Good For The Game
bugfix good
Changelog
🆑
fix: Fixed some guestbook related bugs
/:cl: