Awesome typescript was complaining that backend is an unused property.#4
Merged
DarkXaHTeP merged 3 commits intoDarkXaHTeP:masterfrom Apr 9, 2017
Squidex:master
Merged
Awesome typescript was complaining that backend is an unused property.#4DarkXaHTeP merged 3 commits intoDarkXaHTeP:masterfrom Squidex:master
DarkXaHTeP merged 3 commits intoDarkXaHTeP:masterfrom
Squidex:master
Conversation
Owner
|
@SebastianStehle could you please tell about the reasons for this change? It doesn't make any sense to me at the moment and breaks the build due to changes in dependencies order (you need to update factory inside progress-http.module as well). Thanks! |
Contributor
Author
|
Sorry, changing the order was stupid. The reason for the change is that the typescript compiler is complaining about an unused property "backend". |
Owner
|
@SebastianStehle Thanks for the explanation. Just update the order in module declaration as well and it should work |
Owner
|
@SebastianStehle thanks for the fixes! I'll double check that everything is fine later today and let you know |
Owner
|
@SebastianStehle published your changes to npm as 0.4.1 |
Contributor
Author
|
Awesome, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.