Bump dialyxir to 1.4.7 and adapt to Elixir 1.19#33
Merged
Conversation
- Bump credo to ~> 1.7 (1.6.7 won't compile on Elixir 1.19) - Replace deprecated dialyzer plt_add_deps: :transitive with :app_tree - Move preferred_cli_env into def cli/0 to silence the Mix 1.19 warning
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Replace the Elixir 1.13/1.14 + OTP 24/25 cross-product with explicit pairings on supported releases: 1.17/27, 1.18/27, 1.19/28.
The function name is fixed by the :ssh_client_key_api Erlang behavior callback, so it can't be renamed to host_key?/4.
- key_error.ex: reorder clauses so the algo-specific message is reachable (previously a dead clause, fatal under --warnings-as-errors) - test charlist literals: migrate to ~c"..." sigils so `mix format --check-formatted` passes on Elixir 1.17 (deprecates single-quoted charlists in plain format mode) - workflows: add fail-fast: false so one matrix entry's failure doesn't cancel its siblings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dialyxirfrom 1.2.0 to 1.4.7 (anderlexto 0.2.9).credoto~> 1.7so it compiles on Elixir 1.19 (1.6.7 fails withRegex.CompileError: invalid range in character class).dialyzer: [plt_add_deps: :transitive]with:app_tree(the old value now raises in dialyxir 1.4).preferred_cli_env: [coveralls: :test]out ofdef project/0and into a newdef cli/0block to silence the Mix 1.19 deprecation warning.Test plan
mix deps.getmix test(10 tests, 0 failures)mix dialyzer(Total errors: 0, passed successfully)mix coverallsruns in the:testenv via the newdef cli/0