Optimize dataset info retrieval#273
Merged
Merged
Conversation
cristian-tamblay
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the way dataset metadata is stored and retrieved, making dataset information more accessible and reducing redundant computation. The main improvements are in how metadata such as the number of rows and column names are saved and used.
When saving a dataset using
save_dataset, the metadata file (splits.json) is now enriched to include the total number of rows and the list of column names, making this information directly available without needing to read the data file.The
get_dataset_infofunction now readstotal_rowsandcolumn_namesdirectly from the metadata file instead of computing them by reading the Arrow data file, improving efficiency and consistency.