Fix bug when changing from string to null in forms#281
Merged
Conversation
…nSchema calculation
cristian-tamblay
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
FormSchemaFieldWithOptions.jsxcomponent to optimize how the JSON schema for form fields is computed and to fix a re-render loop bug that occurred when switching parameter types.Bug Description & Reproduction Steps
Previously, the
paramJsonSchemaobject was created inline insidefieldProps, which meant a new object reference was generated on every render. This caused theuseEffectthat depended onfieldProps.paramJsonSchemato run unnecessarily, even when nothing semantically changed.This became a problem when multiple parameters had validation errors:
Why It Happened
paramJsonSchemaobject.useEffectvalidator again, which calledhandleSetError.handleSetErrorcaused the parent list of parameters to re-render.Fix
paramJsonSchemain auseMemohook, with dependencies[title, description, required, options, selectedType].paramJsonSchemaretains the same reference unless one of its dependencies actually changes, breaking the re-render loop and significantly improving performance.Performance and React Optimization
useEffectexecutions on every render.fieldProps.