feat: delete converters and explorers#286
Merged
Merged
Conversation
…y in ExplorerBox in NotebookView
…d for deletion in NotebookView
…confirmation modal in NotebookHistoryModal
…ions in ConverterBox and ExplorerBox
…e theme error color with custom sizing
cristian-tamblay
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces backend and frontend support for deleting converters (and related items) and explorers from notebooks, along with UI improvements for managing converters and explorers. The backend adds a new API endpoint to delete a converter and all subsequent converters and explorers, while the frontend provides delete buttons and confirmation dialogs for these actions. Additionally, the codebase is refactored to improve modularity and maintainability, especially around job queue logic and schema definitions.
Backend: Converter Deletion and Refactoring
DELETE /{converter_list_id}endpoint inconverters.pyto delete a converter list and all subsequent converters and explorers, restore the original dataset, and re-enqueue previous converters as jobs.ConverterParamsandConverterListParamsPydantic models into a newconverter_params.pyschema file, updating imports accordingly for better separation of concerns. [1] [2] [3]_enqueue_job_logicfunction, reducing code duplication injobs.py. [1] [2] [3]Frontend: UI Enhancements for Deletion
ConverterBox,ExplorerBox,ConverterHistoryList) and implemented a newItemsToDeleteListcomponent to display which items will be deleted. [1] [2] [3] [4] [5] [6] [7] [8] [9]deleteConverterByIdto support deletion from the frontend.General Improvements
These changes collectively enable users to safely and efficiently manage (including delete) converter and explorer histories from both backend and frontend, with improved code structure and maintainability.