fix: refactor get_dataset_file to obtain total rows from metadata#287
Merged
Conversation
cristian-tamblay
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the total number of rows is determined in the
get_dataset_fileendpoint. Instead of incrementally counting rows while reading batches from the Arrow file, it now retrieves the total row count using theget_dataset_infofunction, which simplifies the code and fixes the count of rowsDataset row count calculation:
total_rowsduring batch iteration, eliminating the need to incrementally count rows while processing the file. [1] [2]get_dataset_infoto retrieve the total number of rows after batch processing, streamlining the logic and making the code easier to maintain.Before
After