Skip to content

Remove unnecessary steps in explorer/converter modals#300

Merged
cristian-tamblay merged 1 commit into
developfrom
fix/explorer-converter-unnecessary-steps
Sep 22, 2025
Merged

Remove unnecessary steps in explorer/converter modals#300
cristian-tamblay merged 1 commit into
developfrom
fix/explorer-converter-unnecessary-steps

Conversation

@Irozuku
Copy link
Copy Markdown
Collaborator

@Irozuku Irozuku commented Sep 16, 2025

This pull request streamlines the notebook tool configuration workflow by conditionally skipping the parameter configuration step when the selected tool does not require additional parameters. It achieves this by checking the presence of properties in the tool's schema and updating navigation logic and button labels accordingly. The changes affect both converter and explorer creation flows for a more intuitive user experience.

Conditional step navigation and workflow improvements:

  • The configuration steps in ConfigureToolModal.jsx are now dynamically set: if the tool's schema has properties, both "Configure Scope" and "Configure Parameters" steps are shown; otherwise, only "Configure Scope" is presented.
  • In both converter and explorer creation flows (FormConverterSection.jsx, FormExplorerSection.jsx), the navigation after the scope step is updated: if no parameters are required, the process skips directly to saving the tool; otherwise, it proceeds to the parameter configuration step. [1] [2]

Component interface and button label updates:

  • The ScopeStepConverter.jsx and ScopeStepExplorer.jsx components now receive a nextStep callback instead of setStep, allowing conditional navigation logic. [1] [2]
  • The button labels in the scope and parameter steps are dynamically set: "Next" when parameters are required, otherwise "Create Converter" or "Save"/"Create Explorer" as appropriate. [1] [2] [3] [4]

Before
image

After
image

@cristian-tamblay cristian-tamblay merged commit 03e8d67 into develop Sep 22, 2025
5 checks passed
@cristian-tamblay cristian-tamblay deleted the fix/explorer-converter-unnecessary-steps branch September 22, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants