Skip to content

Feat/dataset experiment chaining#301

Merged
cristian-tamblay merged 9 commits into
developfrom
feat/dataset-experiment-chaining
Sep 25, 2025
Merged

Feat/dataset experiment chaining#301
cristian-tamblay merged 9 commits into
developfrom
feat/dataset-experiment-chaining

Conversation

@Irozuku
Copy link
Copy Markdown
Collaborator

@Irozuku Irozuku commented Sep 22, 2025

This pull request refactors the experiment creation flow to support pre-selecting a dataset and improves code maintainability by modularizing step rendering. It also enhances the user experience by allowing users to launch a new experiment directly from the dataset visualization page, with the selected dataset automatically passed to the experiment creation modal.

User Experience Enhancements

  • A "New Experiment" button is added to the dataset visualization page, which navigates to the experiments page and opens the experiment creation modal with the selected dataset pre-filled. [1] [2] [3]
  • The experiment creation modal initializes the experiment's dataset field with the preselected dataset if provided, ensuring a smoother user workflow.
image image

Code Quality and Consistency

  • Step definitions and rendering are now dynamic, reducing duplication and making future changes easier. [1] [2] [3]
  • Redundant imports and logic are removed from NewExperimentModal.jsx, streamlining the component.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the user experience by enabling dataset-to-experiment chaining, allowing users to launch new experiments directly from dataset visualizations with pre-selected datasets. It also improves code maintainability through better modularization of experiment creation steps.

  • Adds a "New Experiment" button to dataset visualization pages that navigates to experiments with pre-selected dataset
  • Refactors experiment step rendering into a reusable utility function with dynamic step configuration
  • Implements conditional step flow that skips dataset selection when a dataset is pre-selected

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Experiments.jsx Adds dataset state management and modal initialization from navigation state
DatasetVisualization.jsx Adds "New Experiment" button that navigates with dataset context
renderStep.js New utility function for dynamic step rendering based on step names
SetNameAndTaskStep.jsx Removes dataset reset behavior to preserve pre-selected datasets
NewExperimentModal.jsx Major refactor supporting pre-selected datasets and dynamic step configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread DashAI/front/src/pages/experiments/Experiments.jsx Outdated
Comment thread DashAI/front/src/components/experiments/NewExperimentModal.jsx Outdated
Comment thread DashAI/front/src/components/experiments/NewExperimentModal.jsx
@Irozuku Irozuku force-pushed the feat/dataset-experiment-chaining branch from 2469cb5 to b34273d Compare September 24, 2025 19:25
@cristian-tamblay cristian-tamblay merged commit 69df57c into develop Sep 25, 2025
5 checks passed
@cristian-tamblay cristian-tamblay deleted the feat/dataset-experiment-chaining branch September 25, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants