Unify notebook dataset creation under DatasetJob workflow#305
Merged
Conversation
…ead of only the endpoint.
…asetsPage to use createDataset
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the dataset creation workflow by removing the direct notebook-to-dataset API endpoint and unifying all dataset creation through the job system. The changes streamline the architecture by having notebook-based dataset creation use the same job workflow as regular dataset uploads.
- Removed the direct
/notebook/{notebook_id}/datasetAPI endpoint and moved functionality to the DatasetJob system - Enhanced DatasetJob to accept an optional
notebook_idparameter for loading datasets from notebooks - Updated frontend to use the unified job-based workflow for both regular and notebook dataset creation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| DashAI/front/src/pages/datasets/Datasets.jsx | Refactored to use job-based workflow and unified dataset polling logic |
| DashAI/front/src/api/notebook.ts | Removed createDatasetFromNotebook function |
| DashAI/front/src/api/job.ts | Added notebook_id parameter and made file optional for dataset jobs |
| DashAI/back/job/dataset_job.py | Enhanced to support notebook-based dataset creation |
| DashAI/back/api/api_v1/schemas/datasets_params.py | Added notebook_id field to schema |
| DashAI/back/api/api_v1/endpoints/notebook.py | Removed create_dataset_from_notebook endpoint |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cristian-tamblay
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and streamlines the process for creating a dataset from a notebook in DashAI. The main changes include removing the old API endpoint for dataset creation from notebooks, updating the job logic to support notebook-based dataset creation, and modifying the frontend to use the new workflow. These updates improve maintainability and unify dataset creation under the job system.
Backend API and Job System Updates:
/notebook/{notebook_id}/datasetAPI endpoint and its associated logic for creating datasets directly from notebooks, shifting this functionality to the job system. [1] [2]DatasetJob) to support an optionalnotebook_idparameter. If provided, the job loads the dataset from the notebook's file path instead of using a dataloader. [1] [2]notebook_idand handle cases where the file input may be null, supporting notebook-based dataset creation.Frontend Workflow and API Usage:
notebook_idparameter. [1] [2]