Skip to content

Feat: prevent modal close#330

Merged
cristian-tamblay merged 1 commit into
developfrom
fix/prevent-modal-close
Oct 20, 2025
Merged

Feat: prevent modal close#330
cristian-tamblay merged 1 commit into
developfrom
fix/prevent-modal-close

Conversation

@Creylay
Copy link
Copy Markdown
Collaborator

@Creylay Creylay commented Oct 15, 2025

Summary

This PR improves user experience by preventing accidental modal closures in DashAI. Previously, modals would close automatically when users clicked outside them (backdrop click), causing data loss and frustration. Now modals only close through explicit user actions via close buttons.

Type of change

  • Front end new feature.
  • Bug fix.

Changes

  • Disabled automatic modal closure on backdrop click for 13 critical modals
  • Disabled ESC key closure (disableEscapeKeyDown)
  • Added visible close buttons (X icon) in modal headers
  • Implemented consistent Cancel/Save button patterns
  • Applied responsive design for different screen sizes

How to Test

  1. Open any modal (Dataset creation, New Experiment, Predictions, etc.)
  2. Try clicking outside the modal - it should NOT close
  3. Verify close button (X) works properly
  4. Confirm Cancel/Save buttons function as expected

Notes

Affects 13 modals across the platform including DatasetModal, NewExperimentModal, PredictionModal, and explainer modals. This change prevents accidental data loss while maintaining full user control over modal interactions.

@Creylay Creylay changed the title feat: add close buttons to various modals for improved user experience Feat: prevent modal close Oct 15, 2025
@cristian-tamblay cristian-tamblay merged commit 74bcf2b into develop Oct 20, 2025
5 checks passed
@cristian-tamblay cristian-tamblay deleted the fix/prevent-modal-close branch October 20, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants