Replace dynamic imports with component registry lookup in converter job class#333
Merged
Conversation
Member
|
Thank you this fixes a lot of import problems in the executables too. I wonder if this exact problem is somewhere else. I think some devs/students didnt get how to use the dependency injection and class instanciation, this is a clear case of this. |
cristian-tamblay
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way converter classes are instantiated in the
converter_job.pyfile. Instead of dynamically importing converter modules using string manipulation andimport_module, the code now retrieves converter classes directly from acomponent_registryprovided by dependency injection. This simplifies the instantiation logic and reduces the risk of import errors.Key changes:
Refactoring converter instantiation:
import_moduleand dynamic module path construction for importing converters, replacing it with a lookup in the injectedcomponent_registryfor the converter class.