Update PermutationFeatureImportance to select samples using fraction#341
Merged
Merged
Conversation
… max_samples_fraction
…ion feature importance tests
cristian-tamblay
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
PermutationFeatureImportanceexplainer to use a fractional value for the number of samples drawn from the test set, instead of an absolute count. This makes the explainer more flexible and better suited for datasets of varying sizes. The parameter and its usage are renamed and refactored throughout the code and schema.Parameter and schema changes:
max_samples(absolute integer) tomax_samples_fraction(float between 0.0 and 1.0) in thePermutationFeatureImportanceSchemaand throughout the explainer class.n_repeatsfrom 10 to 20 for more robust permutation calculations.