Skip to content

Fix column replacement logic in converter job#345

Merged
cristian-tamblay merged 1 commit into
developfrom
fix/variance-threshold
Oct 23, 2025
Merged

Fix column replacement logic in converter job#345
cristian-tamblay merged 1 commit into
developfrom
fix/variance-threshold

Conversation

@Irozuku
Copy link
Copy Markdown
Collaborator

@Irozuku Irozuku commented Oct 21, 2025

This pull request updates the logic for rebuilding datasets with transformed columns in the converter_job.py file. The main focus is on improving how replacement and new columns are determined when transforming scoped columns.

Column replacement and filtering logic:

  • The mapping for column replacement now uses scope_column_names directly instead of sliced transformed columns, ensuring replacements are based on actual column names.
  • The replacement mapping is further filtered to include only columns present in both the transformed and original columns, improving robustness.
  • The identification of new columns is updated to select columns from transformed_cols that are not in scope_column_names, making the logic clearer and more accurate.

@cristian-tamblay cristian-tamblay merged commit db1bf55 into develop Oct 23, 2025
18 checks passed
@cristian-tamblay cristian-tamblay deleted the fix/variance-threshold branch October 23, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants