Skip to content

Feat/tutorial#355

Merged
cristian-tamblay merged 16 commits into
developfrom
feat/tutorial
Nov 5, 2025
Merged

Feat/tutorial#355
cristian-tamblay merged 16 commits into
developfrom
feat/tutorial

Conversation

@Felipedino
Copy link
Copy Markdown
Collaborator

This pull request introduces guided tour functionality throughout the experiment creation and management workflow in the DashAI frontend, and improves backend dataset creation error handling. The main changes include adding context-aware tour step advancement, data attributes for tour step identification, and enhanced duplicate dataset error handling.

Guided Tour Integration:

  • Added useTourContext usage and logic to advance the tour step after key user actions (e.g., opening dialogs, adding models, progressing experiment steps) in ConfigureModelsStep.jsx, ExperimentsTable.jsx, NewExperimentModal.jsx, and RunnerDialog.jsx. [1] [2] [3] [4]
  • Inserted data-tour attributes to critical UI elements (e.g., model selector, add model button, experiments table, runner button, autocomplete fields) to enable precise tour step targeting. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Frontend Feature Enhancements:

  • Added react-joyride dependency to package.json to support the guided tour functionality.
  • Updated event handlers and UI logic in experiment-related components to trigger tour step advancement after user actions, improving onboarding experience. [1] [2] [3] [4] [5] [6] [7]

Backend Improvements:

  • Improved dataset creation in datasets.py by checking for existing dataset names before creation and raising a 409 Conflict error if a duplicate is found, both proactively and on database integrity errors. [1] [2]

Minor Frontend Code Quality Updates:

  • Passed through extra props in ItemSelectorWithInfo.jsx for better component flexibility.
  • Removed unused code and improved error handling in RunnerDialog.jsx. [1] [2]

These changes collectively enhance user onboarding with a guided tour, improve error handling, and increase UI flexibility.

- Added tour context to ConfigureToolModal, RightBar, ConverterList, and FormConverterSection to manage tour steps.
- Implemented tour attributes for buttons and tabs in RightBar and ConverterList.
- Enhanced ParameterStepConverter and ScopeStepConverter to trigger tour steps upon actions.
- Updated Dataset and Explorer components to include tour steps and attributes for better navigation.
- Adjusted tour steps in datasetsTour.js and notebookTour.js to reflect new UI changes and guide users effectively.
- Improved layout and scrolling behavior in FormExplorerSection and other components for better usability during tours.
Remove console.log for debug.
…r improved readability and consistency.

- Updated homeTour.js, notebookTour.js, and index.js to standardize string quotes and formatting.
- Added experimentsTour steps and configurations to index.js.
- Enhanced notebookTour.js with clearer descriptions and consistent formatting.
- Integrated tour context in Results.jsx and ResultsDialogLayout.jsx for better user guidance.
- Added data-tour attributes to various components for improved tour navigation.
- Cleaned up unused code and ensured consistent styling across components.
@Felipedino Felipedino marked this pull request as draft October 27, 2025 16:28
@Felipedino Felipedino marked this pull request as ready for review October 30, 2025 14:45
@cristian-tamblay
Copy link
Copy Markdown
Member

There is a big conflict in Datasets.jsx view. For some reason we cant just keep develop changes

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces an interactive guided tour system using react-joyride to help users navigate through different modules of the DashAI application. The tour provides step-by-step guidance for key workflows including home navigation, dataset upload, notebook creation, and experiment configuration.

Key Changes:

  • Added react-joyride dependency for interactive tours
  • Implemented tour infrastructure with TourProvider, TourButton, and useTour hook
  • Created tour configurations for Home, Datasets, Notebook, and Experiments modules
  • Added data-tour attributes throughout components for tour targeting
  • Removed debug console.log statements from production code

Reviewed Changes

Copilot reviewed 61 out of 63 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
DashAI/front/yarn.lock Updated dependencies including react-joyride and various Babel/build packages
DashAI/front/src/hooks/useTour.js New hook managing tour state and localStorage persistence
DashAI/front/src/components/tour/* New tour components (TourProvider, TourButton) and styling
DashAI/front/src/constants/tours/* Tour step definitions and configurations for each module
DashAI/front/src/pages/* Integration of TourProvider and data-tour attributes
DashAI/front/src/components/notebooks/* Added tour integration points and data-tour attributes
DashAI/front/src/utils/jobPoller.js Removed debug console.log statements
tests/back/job_queue/test_huey_job_queue.py Added time.sleep() calls for test stability
Comments suppressed due to low confidence (1)

DashAI/front/src/constants/tours/experimentsTour.js:1

  • Unused import style.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread DashAI/front/src/hooks/useTour.js Outdated
Comment thread DashAI/front/src/hooks/useTour.js Outdated
Comment thread DashAI/front/src/hooks/useTour.js Outdated
Comment thread DashAI/front/src/components/notebooks/converterCreation/ScopeStepConverter.jsx Outdated
Comment thread DashAI/front/src/constants/tours/experimentsTour.js Outdated
Comment thread DashAI/front/src/components/tour/TourProvider.jsx Outdated
Comment thread DashAI/front/src/components/threeSectionLayout/SelectOptionMenu.jsx Outdated
Comment thread DashAI/front/src/pages/datasets/DatasetsContent.jsx Outdated
Comment thread DashAI/front/src/pages/datasets/DatasetsContent.jsx Outdated
Comment thread DashAI/front/src/pages/datasets/DatasetsContent.jsx Outdated
@cristian-tamblay cristian-tamblay merged commit c20ee49 into develop Nov 5, 2025
18 checks passed
@cristian-tamblay cristian-tamblay deleted the feat/tutorial branch November 5, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants