Skip to content

Fix split experiment#357

Merged
cristian-tamblay merged 5 commits into
developfrom
fix/split-experiment
Oct 30, 2025
Merged

Fix split experiment#357
cristian-tamblay merged 5 commits into
developfrom
fix/split-experiment

Conversation

@Irozuku
Copy link
Copy Markdown
Collaborator

@Irozuku Irozuku commented Oct 27, 2025

This pull request improves the dataset splitting workflow in both the backend and frontend, with a focus on better error handling, validation, and user feedback for dataset splits in experiments. The main changes are the introduction of more precise validation and clearer error messages for both random and manual splits, as well as a minor backend fix to dataset index handling.

Frontend validation and user experience improvements:

  • Added separate error states and messages for random and manual dataset splits, providing clearer feedback to users about split requirements and validation errors.
  • Improved validation logic for random splits to allow for small floating point errors and require all splits to be greater than zero and sum to one.
  • Enhanced manual split validation to ensure each split has at least one row, with immediate feedback when editing indices.
  • Updated UI components to display error states and helper text directly under the relevant inputs for both split types, improving clarity and usability.

Backend fix:

  • Refactored the backend to explicitly assign train, test, and validation indexes from the split configuration.

Comment thread DashAI/front/src/components/experiments/SplitDatasetRows.jsx Outdated
Copy link
Copy Markdown
Member

@cristian-tamblay cristian-tamblay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes to allow 0 split at val/test

@cristian-tamblay cristian-tamblay merged commit 0ac2cd5 into develop Oct 30, 2025
18 checks passed
@cristian-tamblay cristian-tamblay deleted the fix/split-experiment branch October 30, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants