Skip to content

Fix/dataset table refresh#361

Merged
cristian-tamblay merged 4 commits into
developfrom
fix/dataset-table-refresh
Oct 30, 2025
Merged

Fix/dataset table refresh#361
cristian-tamblay merged 4 commits into
developfrom
fix/dataset-table-refresh

Conversation

@Creylay
Copy link
Copy Markdown
Collaborator

@Creylay Creylay commented Oct 28, 2025

Summary

This PR fixes an issue where the converters/explorers table in the notebook view was not updating consistently after deleting a converter. Now, the table waits for the backend job to finish before refreshing, ensuring the UI always reflects the correct state. The approach mirrors the strategy used for dataset creation and deletion.

Type of change

  • Bug fix.

Changes

  • Fixed inconsistent table updates after deleting a converter in the notebook view.
  • Implemented job polling after converter deletion, updating the table only when the backend job completes.
  • Ensured UI consistency by reusing the dataset job-waiting strategy.

How to Test

  1. Open a notebook with multiple converters applied.
  2. Delete the last (or any) converter.
  3. Observe that the table only updates after the backend job finishes, always showing the correct state.
  4. Reloading the page should not change the displayed data (no more inconsistencies).

Screenshots

Notes

  • This fix uses the same polling logic as dataset operations for consistency.
  • No new dependencies were added.

@Creylay Creylay force-pushed the fix/dataset-table-refresh branch from b7516ab to 11705ad Compare October 28, 2025 20:01
@cristian-tamblay cristian-tamblay merged commit 811ffaf into develop Oct 30, 2025
18 checks passed
@cristian-tamblay cristian-tamblay deleted the fix/dataset-table-refresh branch October 30, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants