Fix column select experiment/Refactor input and output columns#369
Merged
Conversation
…gs in experiment parameters
…t; change prop types to strings
… and change prop types to strings
…use string values
cristian-tamblay
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how input and output columns are handled throughout the experiment creation workflow, switching from using column indices (numbers) to using column names (strings). This change affects both backend and frontend code, improving clarity and reducing errors related to column indexing. The update includes changes to API schemas, validation logic, experiment creation, and React component props.
Backend changes:
ExperimentParamsandColumnsValidationParamsschemas now expect lists of column names (List[str]) instead of indices (List[int]).experiments.pynow works directly with column names, removing the need to map indices to names and updating the out-of-range check accordingly.State initialization and management: