Skip to content

Refactor QualityAlerts component to use missing values instead of ratio#379

Merged
cristian-tamblay merged 1 commit into
developfrom
fix/quality-indicator
Nov 14, 2025
Merged

Refactor QualityAlerts component to use missing values instead of ratio#379
cristian-tamblay merged 1 commit into
developfrom
fix/quality-indicator

Conversation

@Irozuku
Copy link
Copy Markdown
Collaborator

@Irozuku Irozuku commented Nov 12, 2025

This pull request updates the dataset quality alert logic to improve how missing values are detected and displayed in the notebook dataset visualization. The main changes involve passing missing value information directly and updating the alert message to be more accurate and user-friendly.

Improvements to missing values detection and display:

  • The DatasetVisualization component now passes the nan field from datasetInfo as the missingValues prop to the QualityAlerts component, ensuring missing value data is available for alerts.
  • The QualityAlerts component is updated to accept the new missingValues prop.
  • The logic for displaying missing value alerts is simplified: instead of only warning for columns with a high missing value ratio, an alert is now shown for any column with missing values, and the alert message lists all affected columns.
image

@Irozuku Irozuku changed the title Replace QualityAlerts component to use missing values instead of ratio Refactor QualityAlerts component to use missing values instead of ratio Nov 12, 2025
@cristian-tamblay cristian-tamblay merged commit 937773c into develop Nov 14, 2025
18 checks passed
@cristian-tamblay cristian-tamblay deleted the fix/quality-indicator branch November 14, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants