Fix some problems with tours and add button#381
Merged
Conversation
…ng TourButton styles
cristian-tamblay
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the onboarding tour experience and refactors how tour-related attributes are applied throughout the notebook and dataset UI. The main changes include making the tour steps more robust by switching to
data-tourattributes, improving the integration of the tour provider and tour button, and simplifying logic for advancing tour steps. Additionally, there are minor UI and code cleanup changes.Tour Experience and Attribute Improvements:
data-tourattributes instead of class names, making them more robust and less likely to break with UI changes. [1] [2] [3] [4] [5]TourProviderandTourButtonintegration to the notebook and dataset panels, ensuring that the tour can be started and controlled contextually depending on the selected view. [1] [2] [3] [4]Tour Step Advancement Logic:
Component and UI Refactoring:
ToolListItemto accept and forward arbitrary props (such asdata-tour), improving flexibility and reducing the need for custom attribute logic in parent components. [1] [2]TourButtonfor better visibility and layering in the UI. [1] [2]These changes collectively enhance the reliability and user experience of the onboarding tours in the application.