Skip to content

Fix some problems with tours and add button#381

Merged
cristian-tamblay merged 1 commit into
developfrom
fix/tour-button
Nov 17, 2025
Merged

Fix some problems with tours and add button#381
cristian-tamblay merged 1 commit into
developfrom
fix/tour-button

Conversation

@Felipedino
Copy link
Copy Markdown
Collaborator

This pull request introduces several improvements to the onboarding tour experience and refactors how tour-related attributes are applied throughout the notebook and dataset UI. The main changes include making the tour steps more robust by switching to data-tour attributes, improving the integration of the tour provider and tour button, and simplifying logic for advancing tour steps. Additionally, there are minor UI and code cleanup changes.

Tour Experience and Attribute Improvements:

  • Refactored tour step selectors to use data-tour attributes instead of class names, making them more robust and less likely to break with UI changes. [1] [2] [3] [4] [5]
  • Added TourProvider and TourButton integration to the notebook and dataset panels, ensuring that the tour can be started and controlled contextually depending on the selected view. [1] [2] [3] [4]
  • Improved tour step configuration by disabling overlays and footers for certain steps, and made content updates for clarity. [1] [2] [3] [4]

Tour Step Advancement Logic:

  • Simplified and standardized logic for advancing tour steps when users interact with tools or select options, removing redundant code and ensuring the tour progresses smoothly for both datasets and notebooks. [1] [2] [3]

Component and UI Refactoring:

  • Updated ToolListItem to accept and forward arbitrary props (such as data-tour), improving flexibility and reducing the need for custom attribute logic in parent components. [1] [2]
  • Adjusted the position and z-index of the TourButton for better visibility and layering in the UI. [1] [2]

These changes collectively enhance the reliability and user experience of the onboarding tours in the application.

@cristian-tamblay cristian-tamblay merged commit 31b8174 into develop Nov 17, 2025
18 checks passed
@cristian-tamblay cristian-tamblay deleted the fix/tour-button branch November 17, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants