Skip to content

Update DashAIDataset to accept InMemoryTable in constructor#403

Merged
Creylay merged 2 commits into
developfrom
fix/translation-task
Dec 16, 2025
Merged

Update DashAIDataset to accept InMemoryTable in constructor#403
Creylay merged 2 commits into
developfrom
fix/translation-task

Conversation

@Irozuku
Copy link
Copy Markdown
Collaborator

@Irozuku Irozuku commented Dec 11, 2025

Summary

This pull request enhances dataset compatibility by allowing the DashAIDataset class to accept both pa.Table and InMemoryTable instances. This resolves issues in translation task that relies on InMemoryTable.


Type of Change

Check all that apply like this [x]:

  • Backend change
  • Frontend change
  • CI / Workflow change
  • Build / Packaging change
  • Bug fix
  • Documentation

Changes (by file)

  • dashai/data/dataset.py:
    • Added import for InMemoryTable from datasets.table.
    • Updated the DashAIDataset constructor to accept Union[pa.Table, InMemoryTable] for the table parameter.

Testing

  • Verify that translation task works

@Irozuku Irozuku added bug Something isn't working back Backend work labels Dec 11, 2025
@Creylay Creylay force-pushed the fix/translation-task branch 2 times, most recently from 782359e to b3ed33b Compare December 15, 2025 21:35
@Creylay Creylay self-requested a review December 16, 2025 19:39
@Creylay Creylay merged commit 99b77a0 into develop Dec 16, 2025
18 checks passed
@Creylay Creylay deleted the fix/translation-task branch December 16, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

back Backend work bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants