Refactor: Unify DatasetVisualization into shared component#418
Merged
Conversation
Irozuku
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates two duplicate
DatasetVisualizationcomponents (one in/componentsfor Notebooks and one in/components/modelsfor Models) into a single shared component with generic props. This reduces code duplication and makes the component reusable across different modules by accepting configurable button text and callback handlers.Type of Change
Check all that apply like this [x]:
Changes (by file)
Component Consolidation:
DashAI/front/src/components/DatasetVisualization.jsx: Updated to use generic prop names (onItemCreated,onNewItem,newItemButtonText,existingItems) instead of notebook-specific names, making it reusable across modulesDashAI/front/src/components/models/DatasetVisualization.jsx: Removed (duplicate component deleted)Integration Updates:
DashAI/front/src/pages/models/ModelsContent.jsx: Updated import to use sharedDatasetVisualizationcomponent from/componentswithnewItemButtonText="New Session"proponNewNotebok→onNewNotebookTesting
Notes