fix numeric formatting and handle null values in NumericTab#538
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the NumericTab dataset analysis UI by making numeric rendering tolerant of missing/invalid values, preventing toFixed() crashes and improving conditional rendering for plots and warnings.
Changes:
- Added
toNumberOrNull/formatNumberhelpers and applied them across displayed numeric statistics. - Made rendering resilient to absent
numericStatsand guarded boxplot/outlier rendering behind data validity checks. - Adjusted warning display conditions (outliers/skewness) to avoid errors when values are missing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cristian-tamblay
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness and user experience of the
NumericTabcomponent by adding safer handling and formatting of numerical statistics, ensuring that missing or invalid data is gracefully displayed as "N/A" instead of causing errors. It also enhances the reliability of the boxplot and warning displays by validating data before rendering.Key improvements:
Robust number handling and formatting:
toNumberOrNullandformatNumberto safely parse and format numeric values, displaying "N/A" when data is missing or invalid. These functions are now used throughout the component for all numeric statistics.Boxplot and outlier display reliability:
Conditional warnings and alerts: