fix: show step numbers instead of check icons in steppers#583
Merged
Conversation
The check icon on completed steps confused users into thinking
validation passed. Force completed={false} so MUI displays the
step number, indicating order only.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cristian-tamblay
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: show step numbers instead of check icons in steppers
The check icon on completed steps confused users into thinking validation passed. Force
completed={false}so MUI displays the step number, indicating order only.Summary
Across all stepper-based modals and dialogs, the MUI
<Step>component was marking previous steps as completed (showing a check icon). This misled users into believing those steps had been validated. Settingcompleted={false}forces MUI to always display the step number (1, 2, 3…), making clear that the stepper indicates order, not validation state.Type of Change
Changes (by file)
DashAI/front/src/components/datasets/DatasetModal.jsx: setcompleted={false}on<Step>DashAI/front/src/components/explainers/InlineExplainerCreator.jsx: setcompleted={false}on<Step>DashAI/front/src/components/explainers/NewGlobalExplainerModal.jsx: setcompleted={false}on<Step>DashAI/front/src/components/explainers/NewLocalExplainerModal.jsx: setcompleted={false}on<Step>DashAI/front/src/components/explorations/ExplorationEditor.jsx: setcompleted={false}on<Step>DashAI/front/src/components/models/AddModelDialog.jsx: addedcompleted={false}prop to<Step>DashAI/front/src/components/models/CreateSessionSteps.jsx: addedcompleted={false}prop to<Step>DashAI/front/src/components/notebooks/tool/ConfigureToolModal.jsx: addedcompleted={false}prop to<Step>Testing