Skip to content

Fix column selector for Explorers and Converters.#598

Merged
cristian-tamblay merged 3 commits into
developfrom
fix/column-selector
May 5, 2026
Merged

Fix column selector for Explorers and Converters.#598
cristian-tamblay merged 3 commits into
developfrom
fix/column-selector

Conversation

@Irozuku
Copy link
Copy Markdown
Collaborator

@Irozuku Irozuku commented May 5, 2026

Summary

This PR fixes the issue where the select all columns button in explorers/converters creation step was not considering columns not visible. Also updates default amount of rows from 5 to 10 on mount.


Type of Change

Check all that apply like this [x]:

  • Backend change
  • Frontend change
  • CI / Workflow change
  • Build / Packaging change
  • Bug fix
  • Documentation

Changes (by file)

Briefly list the important modified files and what was done.

  • DashAI\front\src\components\notebooks\ColumnSelector.jsx: Added a handleSelectAllRows function to properly select all columns and update pagination rows visible on mount.

Testing (optional)

  • Verify that the select all button properly select all the columns including the ones not visible on the table.
  • Verify that the select columns table renders showing 10 rows on mount.

@Irozuku Irozuku added bug Something isn't working front Frontend work labels May 5, 2026
@cristian-tamblay cristian-tamblay merged commit c3ea80c into develop May 5, 2026
19 checks passed
@cristian-tamblay cristian-tamblay deleted the fix/column-selector branch May 5, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working front Frontend work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants