Reduce redundant dataset fetches and standardize notebook API endpoints#620
Merged
cristian-tamblay merged 3 commits intoMay 18, 2026
Merged
Conversation
641badf
into
perf/rows-columns-database
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request standardizes notebook-related API endpoint formatting by ensuring consistent trailing slash usage across notebook API calls. It also improves dataset refresh behavior by only triggering dataset fetches when dataset jobs are finished, reducing unnecessary API requests and redundant dataset reloads.
From the image (running without React StrictMode), only the three necessary fetches are performed with these changes:
Type of Change
Check all that apply like this [x]:
Changes (by file)
Briefly list the important modified files and what was done.
notebook.ts: UpdatednotebookEndpointto consistently use a trailing slash and adjusted notebook-related API calls to avoid malformed URLs or double slashes.useDatasets.ts: Updated job subscription logic to only triggerfetchDatasetswhen aDatasetJobfinishes.DatasetsAndNotebooksProvider.tsx: Removed the initial dataset fetch on mount so datasets are refreshed only when relevant finished jobs are received.Testing (optional)
Notes (optional)