Protectli no shell and no ipxe timeout #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miczyg1
force-pushed
the
protectli_no_shell_and_no_ipxe_timeout
branch
2 times, most recently
from
7e73a0b to
6452900
Compare
macpijan
previously approved these changes
Feb 10, 2025
Contributor
macpijan
left a comment
macpijan
left a comment
There was a problem hiding this comment.
lgtm provided that we resolve https://github.com/Dasharo/edk2/pull/208/files first
miczyg1
force-pushed
the
protectli_no_shell_and_no_ipxe_timeout
branch
from
2b4f981 to
4e73a27
Compare
miczyg1
force-pushed
the
protectli_no_shell_and_no_ipxe_timeout
branch
4 times, most recently
from
cceca83 to
2840303
Compare
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…NSOLE Enabling IPXE_SERIAL_CONSOLE with EDK2 payload or SeaBIOS payload with sercon would cause the output to be doubled. SeaBIOS sercon already handles the VGA INT 10H redirection to serial, so iPXE by printing to VGA and to serial, would result in SeaBIOS and iPXE printing to serial port. In case of EDK2, iPXE uses ConOut to print the output. In a case where EDK2 enables serial console and adds it to ConOut, iPXE would print the output two times on ConOut and serial port explicitly. By disabling the IPXE_SERIAL_CONSOLE we let the payload print the output on the serial console. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
… backed VP2430 does not come with any fans so disable fan curves. Disable UEFI variable option backed as it is not used by Dasharo. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
miczyg1
force-pushed
the
protectli_no_shell_and_no_ipxe_timeout
branch
from
2840303 to
eb74941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.