Add fwupd support / LVFS script#829
Closed
filipleple wants to merge 4 commits intodasharo_developfrom
Closed
Conversation
9b33f6a to
05ca8cb
Compare
Integrate the functionality of capsule_cabinet.sh into capsule.sh. Cabinets can now be created using `./capsule.sh create_cabinet capsule.cap`. Prior functionality and calls of capsule.sh remain unaffected. Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Add a command that allows uploading built cabinets to LVFS. Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Fix the script so that the artifacts match our naming convention. Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
6453a5a to
eb759e5
Compare
Change-Id: I11a5a91ee38c953845135b691b103898ae3830cd Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Member
Author
|
Funny deadlock - can't reopen because the base is wrong; can't change base, because the PR is closed 😃 Addressed the review linking to changes in new PR: #848 |
Member
Oh, I didn't realize that branch was still a target of a PR (I saw you change target in another PR and decided to drop "unused" branch). I think temporary creating the target branch helps in such cases. But do we want to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the functionality of capsule_cabinet.sh into capsule.sh. Cabinets can now be created using
./capsule.sh create_cabinet capsule.cap. Prior functionality and calls of capsule.sh remain unaffected.Upstream-Status: Inappropriate [Dasharo downstream]
issue: Dasharo/dasharo-issues#1432
ref: DSH-1123