build.sh: Fix persmissions when building with GH actions#889
Merged
Conversation
miczyg1
force-pushed
the
ci_fix_25.12
branch
3 times, most recently
from
61eb95b to
54ff308
Compare
SergiiDmytruk
approved these changes
May 14, 2026
Member
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
There was a problem hiding this comment.
LGTM. By the way, I don't get this part of CI (visible here):
${{ env.GH_USERNAME }}:${{ secrets.GH_TOKEN }}
I think it should be just $GH_USERNAME:$GH_TOKEN.
Draft
Contributor
Author
I tired to fix cloning osfv repo, let my try it |
The GH runners have UID 1001, while user coreboot in SDK has id 1000. This creates a mismatch of IDs and causes permission problems when mounting coreboot git repository under /home/coreboot/coreboot in the container, because the /home/coreboot is a HOME directory of different user. To fix the problem, move the mountpoint to a "neutral" place, where permissions should not be a an issue. The /build directory is chosen so that it does not collide with any HOME directory or system directory. Upstream-Status: Inappropriate [Dasharo CI] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Using iPXE master revision may lead to unreproducible builds. Make sure the iPXE is buitl from a fixed revision pointed by IPXE_STABLE option. Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Contributor
Author
Nah, it still didn't fix it: https://github.com/Dasharo/coreboot/compare/1d9f3c0be80264f2bf68e17ba1babdaba0ceab85..de39f9a776ede1fc3d4792673789e06563a6c338 Locally the access token works perfectly though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GH runners have UID 1001, while user coreboot in SDK has id 1000. This creates a mismatch of IDs and causes permission problems when mounting coreboot git repository under /home/coreboot/coreboot in the container, because the /home/coreboot is a HOME directory of different user.
To fix the problem, move the mountpoint to a "neutral" place, where permissions should not be a an issue. The /build directory is chosen so that it does not collide with any HOME directory or system directory.