Add flashrom job scheduling and flash fd first #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Flow
For now tested under qemu Profile example
Flow: Heads update for z790 DDR5 under qemu. |
Contributor
pre-commit installAlso this change will require updating probably every profile we have in OSFV |
m-iwanicki
requested changes
Dec 10, 2025
3mkusiak
commented
Dec 11, 2025
Instead of executing flashrom in place, schedule them and execute one after another. This is basically a workaround for fragmented flashrom parameter logic. This way we know all flashrom jobs before executing them. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
If FD is to be flashed, flash the FD before flashing anything else. The reason is regions are FD dependent. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Make progress bar standalone to be reusable. It should be used only for drawing the progress bar, and not contain any logic. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Move drawing progress bar function to dts-functions.sh Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Use progress bar for flashrom jobs instead of printing messages. Add scheduling info for remaining fobs. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Contributor
Author
|
Rebased on top of newest main. |
m-iwanicki
reviewed
Dec 15, 2025
Add progress bar wrapper to avoid code repetition. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Contributor
Author
|
This is how it currently looks like: Details
|
For the scheduling to work reliably, the parameters must be stored as arrays, not as strings. Use dynamic arrays for adding flashrom parameters. Additionally improve fd flashing detection mechanism. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Contributor
Author
|
Converted to draft, need to run E2E to verify this truly works. |
3mkusiak
added a commit
to Dasharo/open-source-firmware-validation
that referenced
this pull request
Dec 17, 2025
This commit updates profiles for platforms that need FD flashing in deployment, update and heads transition workflows. The change is that if FD is being flashed, it'll get a dedicated job first. Related to: Dasharo/dts-scripts#130 Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Contributor
Author
|
Proved this works, need to documment that code though. |
Contributor
|
There are still couple of places where we are possibly flashing fd once:
Those places also have to be fixed to close issue:
Transition is more important than recovery as we don't even have tests for those. |
Add wrapper function for transition and recovery workflows that detects if fd is being flashed, and if so, runs dedicated flashrom job for FD flashing. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Contributor
Author
|
Addressed, though still need to test it. |
3mkusiak
added a commit
to Dasharo/open-source-firmware-validation
that referenced
this pull request
Dec 18, 2025
This commit updates profiles for platforms that need FD flashing in deployment, update and heads transition workflows. The change is that if FD is being flashed, it'll get a dedicated job first. Related to: Dasharo/dts-scripts#130 Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Contributor
Author
|
Added some minor documentation to the function, I believe it's ready to review. |
m-iwanicki
requested changes
Dec 18, 2025
This commit adds a bunch of comment to deploy_firmware() so the function is more readable. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
m-iwanicki
pushed a commit
to Dasharo/open-source-firmware-validation
that referenced
this pull request
Dec 19, 2025
This commit updates profiles for platforms that need FD flashing in deployment, update and heads transition workflows. The change is that if FD is being flashed, it'll get a dedicated job first. Related to: Dasharo/dts-scripts#130 Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
m-iwanicki
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Dasharo/dasharo-issues#1592