osfv/models/NUC BOX.yml: add #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
matmacieje
reviewed
Jun 18, 2025
Contributor
There was a problem hiding this comment.
This file should be named "NUC BOX-125H.yml" for snipeit model naming compatibility (please refer to my next comment).
osfv_cli/src/osfv/rf/rte_robot.py
Outdated
| "msi-pro-z790-p-ddr5": "MSI PRO Z790-P DDR5", | ||
| "novacustom-ns50mu": "NS50MU", | ||
| "novacustom-v540tu": "V540TU", | ||
| "novacustom-nuc_box": "NUC BOX", |
Contributor
There was a problem hiding this comment.
In snipeit we have now three NUC BOX models, when running osfv_cli with rte_ip there's an error: unsupported model. This should be changed to "NUC BOX-125H" to avoid snipeit name conflict.
Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
philipanda
reviewed
Jul 16, 2025
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
philipanda
approved these changes
Jul 16, 2025
Contributor
philipanda
left a comment
philipanda
left a comment
There was a problem hiding this comment.
It would be better to somehow say that external flashing is not supported so that it fails quicker, but that's a different topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.