fix: use toDate instead of toDateTime for cohort event_date comparison#201
Merged
ayushjhanwar-png merged 1 commit intomainfrom Mar 12, 2026
Merged
fix: use toDate instead of toDateTime for cohort event_date comparison#201ayushjhanwar-png merged 1 commit intomainfrom
ayushjhanwar-png merged 1 commit intomainfrom
Conversation
toDateTime is affected by session_timezone, shifting dates by the timezone offset. This causes cohort membership queries against the event_date (Date type) column to return 0 rows for narrow date ranges. toDate is timezone-independent and correctly matches Date columns.
harshitsaamu
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toDateTime is affected by session_timezone, shifting dates by the timezone offset. This causes cohort membership queries against the event_date (Date type) column to return 0 rows for narrow date ranges. toDate is timezone-independent and correctly matches Date columns.