fix: use conversion rate (%) for alerts on conversion/funnel charts#209
Merged
ayushjhanwar-png merged 1 commit intomainfrom Mar 19, 2026
Merged
fix: use conversion rate (%) for alerts on conversion/funnel charts#209ayushjhanwar-png merged 1 commit intomainfrom
ayushjhanwar-png merged 1 commit intomainfrom
Conversation
ayushjhanwar-png
commented
Mar 18, 2026
ayushjhanwar-png
commented
- cron.custom-alerts: route conversion charts to conversionService and funnel charts to funnelService instead of ChartEngine, so anomaly and threshold evaluation uses the actual conversion rate percentage (e.g. 88.63%) rather than raw event counts (e.g. 1660827)
- cron.custom-alerts: append ?range= to Slack report links so the link opens scoped to the alert's evaluation window (today, lastHour, etc.)
- report-editor: apply ?range= URL param as a one-shot override on load so Slack links open the chart with the correct time range
- report route: add range to validateSearch so TanStack Router preserves the param instead of stripping it
- add-notification-rule: show % suffix and percentage placeholder on threshold value input when selected report is conversion or funnel
- rule-card: show % after threshold value for conversion/funnel reports
- trpc report.listByProject: include chartType in select
- cron.custom-alerts: route conversion charts to conversionService and funnel charts to funnelService instead of ChartEngine, so anomaly and threshold evaluation uses the actual conversion rate percentage (e.g. 88.63%) rather than raw event counts (e.g. 1660827) - cron.custom-alerts: append ?range= to Slack report links so the link opens scoped to the alert's evaluation window (today, lastHour, etc.) - report-editor: apply ?range= URL param as a one-shot override on load so Slack links open the chart with the correct time range - report route: add range to validateSearch so TanStack Router preserves the param instead of stripping it - add-notification-rule: show % suffix and percentage placeholder on threshold value input when selected report is conversion or funnel - rule-card: show % after threshold value for conversion/funnel reports - trpc report.listByProject: include chartType in select
harshitsaamu
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.