Skip to content

fix: correct line-height and hamburger overlay on mobile/large screens#433

Merged
DatGreekChick merged 2 commits intomainfrom
fix/mobile-ui-fixes
Apr 18, 2026
Merged

fix: correct line-height and hamburger overlay on mobile/large screens#433
DatGreekChick merged 2 commits intomainfrom
fix/mobile-ui-fixes

Conversation

@DatGreekChick
Copy link
Copy Markdown
Owner

@DatGreekChick DatGreekChick commented Apr 18, 2026

Summary

  • Removes line-height: 1 from .callToActionText and .callToActionAnchor in Uses.module.css — the tight value caused cramped spacing when CTA text wrapped on mobile
  • Changes .menuList top from 8.5% to 4rem in Hamburger.module.css — the percentage-based value created a gap on large/tall screens where page content (e.g. the resume button on /work) was visible behind the open menu overlay

Test plan

  • View the Uses page on mobile and confirm the CTA under "Podcasts" has natural line spacing
  • Open the hamburger menu on a large screen and confirm the overlay covers content flush to the navbar (no resume button peeking through at the top on /work)

🤖 Generated with Claude Code

DatGreekChick and others added 2 commits April 18, 2026 18:41
line-height: 1 caused cramped spacing on mobile when CTA text wrapped.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
top: 8.5% created a gap on tall viewports where page content was
visible behind the open menu. Changed to top: 4rem to match the
existing height: calc(100% - 4rem).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6283415) to head (7f4c29c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #433   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          110       110           
=========================================
  Hits           110       110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 7f4c29c):

https://elenicodes--pr433-fix-mobile-ui-fixes-urzj486o.web.app

(expires Sat, 25 Apr 2026 22:48:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2893a00bbe8f1f8b2d040782481f3b83b74bae08

@DatGreekChick DatGreekChick merged commit d79144a into main Apr 18, 2026
5 checks passed
@DatGreekChick DatGreekChick deleted the fix/mobile-ui-fixes branch April 18, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant