Skip to content

Bug fix - homogenized_tangent was not being written #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2025
Merged

Bug fix - homogenized_tangent was not being written #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0baf78
make writeData for tangent collective
sanathkeshav Nov 6, 2025
c53daf3
add changelog entry
sanathkeshav Nov 6, 2025
52443bb
check if J2Plasticity and dont let homogenized_tangent be computed
sanathkeshav Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# FANS Changelog

## latest

- Bugfix: `homogenized_tangent` was computed but not written to HDF5 output [#113](https://github.com/DataAnalyticsEngineering/FANS/pull/113)

## v0.5.2

- Bugfix: Fix bad initial guess for time steps > 0 [#109](https://github.com/DataAnalyticsEngineering/FANS/pull/109)
Expand Down
7 changes: 6 additions & 1 deletion include/solver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

#include "matmodel.h"

class J2Plasticity;

typedef Map<Array<double, Dynamic, Dynamic>, Unaligned, OuterStride<>> RealArray;

template <int howmany, int n_str>
Expand Down Expand Up @@ -610,8 +612,8 @@ void Solver<howmany, n_str>::postprocess(Reader &reader, int load_idx, int time_
cout << "# Homogenized tangent: " << endl
<< setprecision(12) << homogenized_tangent << endl
<< endl;
reader.writeData("homogenized_tangent", load_idx, time_idx, homogenized_tangent.data(), dims, 2);
}
reader.writeData("homogenized_tangent", load_idx, time_idx, homogenized_tangent.data(), dims, 2);
}
extrapolateDisplacement(); // prepare v_u for next time step
}
Expand Down Expand Up @@ -660,6 +662,9 @@ MatrixXd Solver<howmany, n_str>::get_homogenized_tangent(double pert_param)
this->reader.errorParameters["type"] = "relative";
this->TOL = max(1e-6, this->TOL);

if (dynamic_cast<J2Plasticity *>(this->matmodel) != nullptr) {
throw std::runtime_error("Homogenized tangent computation not implemented for J2Plasticity models.");
}
// TODO: a deep copy of the solver object is needed here to avoid modifying the history of the solver object

for (int i = 0; i < n_str; i++) {
Expand Down