Skip to content

Promotion 2024-11-12 prod (#6699)#6711

Merged
dsotirho-ucsc merged 40 commits intoprodfrom
promotions/2024-11-12-prod
Nov 15, 2024
Merged

Promotion 2024-11-12 prod (#6699)#6711
dsotirho-ucsc merged 40 commits intoprodfrom
promotions/2024-11-12-prod

Conversation

@dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented Nov 15, 2024

Connected issue: #6699

Notes

  • Manually reindex lm8

Checklist

Author

  • Target branch is prod
  • Name of PR branch matches promotions/yyyy-mm-dd-prod
  • On ZenHub, PR is connected to the promotion issue it resolves
  • PR description links to connected issue
  • Title of connected issue matches Promotion yyyy-mm-dd
  • PR title starts with title of connected issue followed by prod
  • PR title references the connected issue

Author (reindex, API changes)

  • This PR is labeled reindex:prod or the changes introduced by it will not require reindexing of prod
  • This PR is labeled reindex:partial and its description documents the specific reindexing procedure for prod or requires a full reindex or is not labeledreindex:prod

Author (upgrading deployments)

  • This PR is labeled upgrade or does not require upgrading deployments
  • This PR is labeled deploy:shared or does not modify docker_images.json, and does not require deploying the shared component for any other reason
  • This PR is labeled deploy:gitlab or does not require deploying the gitlab component
  • This PR is labeled deploy:runner or does not require deploying the runner image

System administrator (after approval)

  • Actually approved the PR
  • Labeled PR as no sandbox
  • Moved connected issue to Approved column
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Pushed PR branch to GitHub
  • Ran _select prod.shared && CI_COMMIT_REF_NAME=prod make -C terraform/shared apply or this PR is not labeled deploy:shared
  • Made a backup of the GitLab data volume in prod (see operator manual for details) or this PR is not labeled backup:gitlab
  • Ran _select prod.gitlab && CI_COMMIT_REF_NAME=prod make -C terraform/gitlab apply or this PR is not labeled deploy:gitlab
  • Checked the items in the next section or this PR is labeled deploy:gitlab
  • PR is assigned to only the system administrator or this PR is not labeled deploy:gitlab

System administrator

  • Background migrations for prod.gitlab are complete or this PR is not labeled deploy:gitlab
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Ran _select prod.gitlab && make -C terraform/gitlab/runner or this PR is not labeled deploy:runner
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Pushed merge commit to GitLab prod
  • Build passes on GitLab prod
  • Reviewed build logs for anomalies on GitLab prod
  • Deleted PR branch from GitHub
  • Moved connected issue to Merged stable column on ZenHub
  • Moved promoted issues from Merged lower to Merged stable column on ZenHub
  • Moved promoted issues from Lower to Stable column on ZenHub

Operator (reindex)

  • Deindexed all unreferenced catalogs in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Deindexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Indexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Started reindex in prod or this PR does not require reindexing prod
  • Checked for, triaged and possibly requeued messages in both fail queues in prod or this PR does not require reindexing prod
  • Emptied fail queues in prod or this PR does not require reindexing prod

Operator

  • PR is assigned to only the system administrator

System administrator

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

nadove-ucsc and others added 30 commits November 4, 2024 21:40
This fix is untested since it touches code that is disabled (conditional upon DSS direct access).
@coveralls
Copy link

Coverage Status

coverage: 85.613% (+0.2%) from 85.368%
when pulling efe016f on promotions/2024-11-12-prod
into 6da5ddb on prod.

@dsotirho-ucsc dsotirho-ucsc added reindex:anvilprod [process] PR requires reindexing anvilprod reindex:partial [process] PR allows for (de)indexing a specific source or catalog reindex:prod [process] PR requires reindexing prod and removed reindex:anvilprod [process] PR requires reindexing anvilprod labels Nov 15, 2024
@hannes-ucsc hannes-ucsc added the no sandbox [process] PR will not be tested in the sandbox label Nov 15, 2024
@dsotirho-ucsc dsotirho-ucsc merged commit 064f29a into prod Nov 15, 2024
@dsotirho-ucsc dsotirho-ucsc deleted the promotions/2024-11-12-prod branch November 15, 2024 23:08
@hannes-ucsc hannes-ucsc removed their assignment Nov 20, 2024
@hannes-ucsc hannes-ucsc linked an issue Sep 12, 2025 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no sandbox [process] PR will not be tested in the sandbox reindex:partial [process] PR allows for (de)indexing a specific source or catalog reindex:prod [process] PR requires reindexing prod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promotion 2024-11-12

5 participants