Skip to content

Conversation

@dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented Jan 22, 2025

Checklist

Author

  • Target branch is develop
  • Name of PR branch matches backports/<7-digit SHA1 of most recent backported commit>
  • PR title contains the 7-digit SHA1 of the backported commits
  • PR title references the issues relating to the backported commits
  • PR title references the PRs that introduced the backported commits

Author (before every review)

  • Merged develop into PR branch to integrate upstream changes
  • Ran make requirements_update or this PR does not modify requirements*.txt, common.mk, Makefile and Dockerfile
  • Added R tag to commit title or this PR does not modify requirements*.txt
  • This PR is labeled reqs or does not modify requirements*.txt

System administrator (after approval)

  • Actually approved the PR
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • Moved connected issue to Approved column
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Sanity-checked history
  • Pushed PR branch to GitHub
  • Added sandbox label or PR is labeled no sandbox
  • Pushed PR branch to GitLab dev or PR is labeled no sandbox
  • Pushed PR branch to GitLab anvildev or PR is labeled no sandbox
  • Build passes in sandbox deployment or PR is labeled no sandbox
  • Build passes in anvilbox deployment or PR is labeled no sandbox
  • Reviewed build logs for anomalies in sandbox deployment or PR is labeled no sandbox
  • Reviewed build logs for anomalies in anvilbox deployment or PR is labeled no sandbox
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference (to this PR) to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Pushed merge commit to GitLab dev
  • Pushed merge commit to GitLab anvildev
  • Build passes on GitLab dev
  • Reviewed build logs for anomalies on GitLab dev
  • Build passes on GitLab anvildev
  • Reviewed build logs for anomalies on GitLab anvildev
  • Deleted PR branch from GitHub
  • Deleted PR branch from GitLab dev
  • Deleted PR branch from GitLab anvildev

Operator

  • PR is assigned to no one

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (935f10b) to head (0f93378).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6840   +/-   ##
========================================
  Coverage    85.64%   85.64%           
========================================
  Files          149      149           
  Lines        21040    21040           
========================================
  Hits         18020    18020           
  Misses        3020     3020           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 85.663%. remained the same
when pulling 0f93378 on backports/e3586cc
into 935f10b on develop.

@hannes-ucsc hannes-ucsc added the no sandbox [process] PR will not be tested in the sandbox label Jan 22, 2025
@hannes-ucsc hannes-ucsc merged commit d4b1619 into develop Jan 22, 2025
9 checks passed
@dsotirho-ucsc dsotirho-ucsc deleted the backports/e3586cc branch January 22, 2025 20:33
@dsotirho-ucsc dsotirho-ucsc removed their assignment Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no sandbox [process] PR will not be tested in the sandbox

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants