Skip to content

Promotion 2025-12-09 prod (#7628)#7636

Merged
dsotirho-ucsc merged 25 commits intoprodfrom
promotions/2025-12-09-prod
Dec 12, 2025
Merged

Promotion 2025-12-09 prod (#7628)#7636
dsotirho-ucsc merged 25 commits intoprodfrom
promotions/2025-12-09-prod

Conversation

@dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented Dec 9, 2025

Linked issue: #7628

Notes:

Checklist

Author

  • PR is assigned to the author
  • Status of PR is In progress
  • Target branch is prod
  • Name of PR branch matches promotions/yyyy-mm-dd-prod
  • PR is linked to the promotion issue it resolves
  • Status of linked issue is In progress
  • PR description links to linked issue
  • Title of linked issue matches Promotion yyyy-mm-dd
  • PR title starts with title of linked issue followed by prod
  • PR title references the linked issue

Author (reindex)

  • This PR is labeled reindex:prod or the changes introduced by it will not require reindexing of prod
  • This PR is labeled reindex:partial and its description documents the specific reindexing procedure for prod or requires a full reindex or is not labeledreindex:prod

Author (upgrading deployments)

  • This PR is labeled upgrade or does not require upgrading deployments
  • This PR is labeled deploy:shared or does not modify docker_images.json, and does not require deploying the shared component for any other reason
  • This PR is labeled deploy:gitlab or does not require deploying the gitlab component
  • This PR is labeled deploy:runner or does not require deploying the runner image

Author (before every review)

  • PR branch is up to date (if not, merge prod into PR branch to integrate upstream changes)
  • PR is not a draft
  • PR is awaiting requested review from system administrator
  • Status of PR is Review requested
  • PR is assigned to only the system administrator and the author

System administrator (after approval)

  • Actually approved the PR
  • Labeled PR as no sandbox
  • N reviews label is accurate
  • Status of PR is Approved
  • PR is assigned to only the operator and the author

Operator

  • Pushed PR branch to GitHub

Operator (deploy .shared and .gitlab components)

  • Ran _select prod.shared && CI_COMMIT_REF_NAME=prod make -C terraform/shared apply_keep_unused or this PR is not labeled deploy:shared
  • Ran _select prod.gitlab && python scripts/create_gitlab_snapshot.py --no-restart (see operator manual for details) or this PR is not labeled backup:gitlab
  • Ran _select prod.gitlab && CI_COMMIT_REF_NAME=prod make -C terraform/gitlab apply or this PR is not labeled deploy:gitlab
  • Checked the items in the next section or this PR is labeled deploy:gitlab
  • PR is assigned to only the system administrator and the author or this PR is not labeled deploy:gitlab

System administrator (post-deploy of .gitlab component)

  • Background migrations for prod.gitlab are complete or this PR is not labeled deploy:gitlab
  • PR is assigned to only the operator and the author

Operator (deploy runner image)

  • Ran _select prod.gitlab && make -C terraform/gitlab/runner or this PR is not labeled deploy:runner

Operator (merge the branch)

  • All status checks passed and the PR is mergeable
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Pushed merge commit to GitHub
  • Status of PR is Merged stable

Operator (main build)

  • Pushed merge commit to GitLab prod
  • Build passes on GitLab prod
  • Reviewed build logs for anomalies on GitLab prod
  • Ran _select prod.shared && make -C terraform/shared apply or this PR is not labeled deploy:shared
  • Deleted PR branch from GitHub
  • PR is assigned to only the operator
  • Status of linked issue is Stable
  • Status of promoted1 PRs is Merged stable
  • Status of promoted1 issues is Stable

1 Promoted issues and PRs are referenced in the titles of the commits
that the promotion branch introduces to the stable branch. Prior to the
promotion, the status of promoted issues (PRs) is Lower (Merged lower).
Promoted PRs in status Done do not need to be moved.

Operator (reindex)

  • Deindexed all unreferenced catalogs in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Deindexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Indexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Started reindex in prod or this PR does not require reindexing prod
  • Checked for, triaged and possibly requeued messages in both fail queues in prod or this PR does not require reindexing prod
  • Emptied fail queues in prod or this PR does not require reindexing prod
  • Restarted the Data Browser pipeline for the ucsc/hca/prod branch on GitLab in prod or this PR does not require reindexing prod
  • Restarted the Data Browser pipeline for the ucsc/lungmap/prod branch on GitLab in prod or this PR does not require reindexing prod
  • Restarted deploy_browser job in the GitLab pipeline for this PR in prod or this PR does not require reindexing prod

Operator (mirroring)

  • Started mirroring in prod or this PR does not require mirroring prod
  • Checked for, triaged and possibly requeued messages in mirror fail queue in prod or this PR does not require mirroring prod
  • Emptied mirror fail queue in prod or this PR does not require mirroring prod

Operator

  • PR is assigned to only the system administrator

System administrator

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

nadove-ucsc and others added 24 commits December 3, 2025 11:27
@dsotirho-ucsc dsotirho-ucsc self-assigned this Dec 9, 2025
@dsotirho-ucsc dsotirho-ucsc linked an issue Dec 9, 2025 that may be closed by this pull request
8 tasks
@dsotirho-ucsc dsotirho-ucsc added reindex:prod [process] PR requires reindexing prod reindex:partial [process] PR allows for (de)indexing a specific source or catalog labels Dec 9, 2025
@coveralls
Copy link

coveralls commented Dec 9, 2025

Coverage Status

coverage: 85.079% (-0.07%) from 85.153%
when pulling 7e65530 on promotions/2025-12-09-prod
into adc5df2 on prod.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 39.16667% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.85%. Comparing base (adc5df2) to head (7e65530).
⚠️ Report is 26 commits behind head on prod.

Files with missing lines Patch % Lines
test/integration_test.py 0.00% 66 Missing ⚠️
src/azul/drs.py 84.21% 6 Missing ⚠️
src/azul/indexer/mirror_service.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             prod    #7636      +/-   ##
==========================================
- Coverage   84.93%   84.85%   -0.08%     
==========================================
  Files         157      157              
  Lines       22725    22771      +46     
==========================================
+ Hits        19301    19323      +22     
- Misses       3424     3448      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hannes-ucsc hannes-ucsc added no sandbox [process] PR will not be tested in the sandbox 0 reviews [process] Lead didn't request any changes labels Dec 11, 2025
@hannes-ucsc hannes-ucsc removed their assignment Dec 11, 2025
@dsotirho-ucsc dsotirho-ucsc merged commit eab0f07 into prod Dec 12, 2025
8 checks passed
@dsotirho-ucsc dsotirho-ucsc deleted the promotions/2025-12-09-prod branch December 12, 2025 23:25
@hannes-ucsc hannes-ucsc removed their assignment Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 reviews [process] Lead didn't request any changes no sandbox [process] PR will not be tested in the sandbox reindex:partial [process] PR allows for (de)indexing a specific source or catalog reindex:prod [process] PR requires reindexing prod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promotion 2025-12-09

5 participants