Fix: OutOfMemory error in mirror Lambda function (#7730) by nadove-ucsc · Pull Request #7795 · DataBiosphere/azul

nadove-ucsc · 2026-02-20T05:28:22Z

Linked issues: #7730

Checklist

Author

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all linked issues}
This PR partially resolves each of the linked issues _{or does not have the partial label}

Author (reindex)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}

Author (API changes)

This PR and its linked issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make docker_images.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any linked issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues linked to this PR}

Author (before every review)

Rebased PR branch on develop, squashed fixups from prior reviews
Ran make requirements_update _{or this PR does not modify Dockerfile, environment, requirements*.txt, common.mk, Makefile or environment.boot}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}
PR is awaiting requested review from a peer
Status of PR is Review requested
PR is assigned to only the peer and the author

Peer reviewer (after approval)

Note that after requesting changes, the PR must be assigned to only the author.

Actually approved the PR
PR is not a draft
PR is awaiting requested review from system administrator
Status of PR is Review requested
PR is assigned to only the system administrator and the author

System administrator (after approval)

Actually approved the PR
Labeled linked issues as demo or no demo
Commented on linked issues about demo expectations _{or all linked issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Status of PR is Approved
PR is assigned to only the operator and the author

Operator

Checked reindex:… labels and r commit title tag
Checked that demo expectations are clear _{or all linked issues are labeled no demo}
Squashed PR branch and rebased onto develop
Sanity-checked history
Pushed PR branch to GitHub

Operator (deploy `.shared` and `.gitlab` components)

Ran _select dev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select dev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Ran _select anvildev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select anvildev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Checked the items in the next section _{or this PR is labeled deploy:gitlab}
PR is assigned to only the system administrator and the author _{or this PR is not labeled deploy:gitlab}

System administrator (post-deploy of `.gitlab` component)

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator and the author

Operator (deploy runner image)

Ran _select dev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}
Ran _select anvildev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}

Operator (sandbox build)

Operator (merge the branch)

All status checks passed and the PR is mergeable
The title of the merge commit starts with the title of this PR
Added PR # reference to merge commit title
Collected commit title tags in merge commit title _{but only included p if the PR is also labeled partial}
Pushed merge commit to GitHub
Status of PR is Merged lower
Status of blocked issues is Triage _{or no issues are blocked on the linked issues}

Operator (main build)

Operator (reindex)

Operator (mirroring)

Started mirroring in dev _{or this PR does not require mirroring dev}
Started mirroring in anvildev _{or this PR does not require mirroring anvildev}
Checked for, triaged and possibly requeued messages in mirror fail queue in dev _{or this PR does not require mirroring dev}
Checked for, triaged and possibly requeued messages in mirror fail queue in anvildev _{or this PR does not require mirroring anvildev}
Emptied mirror fail queue in dev _{or this PR does not require mirroring dev}
Emptied mirror fail queue in anvildev _{or this PR does not require mirroring anvildev}

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

coveralls · 2026-02-20T05:47:46Z

coverage: 85.26% (-0.03%) from 85.286%
when pulling 3fd9d21 on issues/nadove-ucsc/7730-outofmemory-error-mirror-lambda-function
into bf1399e on develop.

codecov · 2026-02-20T05:48:35Z

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.04%. Comparing base (bf1399e) to head (3fd9d21).

Files with missing lines	Patch %	Lines
src/azul/terraform.py	0.00%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7795      +/-   ##
===========================================
- Coverage    85.07%   85.04%   -0.03%     
===========================================
  Files          157      157              
  Lines        23293    23300       +7     
===========================================
  Hits         19816    19816              
- Misses        3477     3484       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hannes-ucsc · 2026-02-20T06:59:01Z

src/azul/terraform.py


+        # Prevent AWS from automatically updating the lambda runtime
+        resource_type = 'aws_lambda_runtime_management_config'
+        runtime_version = '1a6363019b274fc28ffbbec073e5ebf1a872c10c52269844a57c62e74063a49b'


Need brief explanation why we are pinning the version, what the human-readable semantic version is that we're are pinning, and a FIXME referring to a new issue to remove the pin.

Leave a comment on the new ticket about the following spike:

We need to file an issue with AWS support about the increased memory usage of the affected runtime version. For that it would be useful to have two previous MirrorFileAction invocations one from after the automatic update to the affected runtime version, and one from the subsequent experiment that Daniel preformed with the version pinned to the unaffected version. Ideally both invocations should be for the same file.

hannes-ucsc · 2026-02-21T02:39:29Z

src/azul/terraform.py

+        # Pin lambda runtime to python:3.13.v76. When AWS automatically updated
+        # the runtime to 3.13v77, we observed a significant increase in memory
+        # usage, leading to mirroring failures.
+        # FIXME: Remove pinned lambda runtime version
+        #        https://github.com/DataBiosphere/azul/issues/7798


Suggested change

# Pin lambda runtime to python:3.13.v76. When AWS automatically updated

# the runtime to 3.13v77, we observed a significant increase in memory

# usage, leading to mirroring failures.

# FIXME: Remove pinned lambda runtime version

# https://github.com/DataBiosphere/azul/issues/7798

# Pin Lambda runtime to python:3.13.v76. When AWS automatically updated

# the runtime to 3.13v77, we observed a significant increase in memory

# usage, leading to mirroring failures.

#

# FIXME: Remove pinned lambda runtime version

# https://github.com/DataBiosphere/azul/issues/7798

#

hannes-ucsc · 2026-02-21T02:46:23Z

src/azul/terraform.py

+        #        https://github.com/DataBiosphere/azul/issues/7798
+        resource_type = 'aws_lambda_runtime_management_config'
+        runtime_version = '1a6363019b274fc28ffbbec073e5ebf1a872c10c52269844a57c62e74063a49b'
+        management_resources: MutableJSON = {}


Suggested change

management_resources: MutableJSON = {}

runtime_version_configs: MutableJSON = {}

hannes-ucsc · 2026-02-21T02:49:41Z

src/azul/terraform.py

+        management_resources: MutableJSON = {}
+        for resource_name, resource in resource_items('aws_lambda_function'):
+            management_resources[resource_name] = {
+                'function_name': f'${{aws_lambda_function.{resource_name}.function_name}}',


Overwhelmingly, precedent is to use % when curlies occur naturally in the literal. Daniel snuck in f'${{ but that's a mistake.

hannes-ucsc · 2026-02-21T02:51:21Z

src/azul/terraform.py

+                'function_name': f'${{aws_lambda_function.{resource_name}.function_name}}',
+                'qualifier': f'${{aws_lambda_function.{resource_name}.version}}',
+                'update_runtime_on': 'Manual',
+                'runtime_version_arn': f'arn:aws:lambda:us-east-1::runtime:{runtime_version}'


and then % here, too for visual consistency. Or just +

hannes-ucsc · 2026-02-21T02:53:57Z

While it's fine to skip peer review, I'd prefer the author to check those CL items if they decide to do so.

nadove-ucsc self-assigned this Feb 20, 2026

nadove-ucsc linked an issue Feb 20, 2026 that may be closed by this pull request

OutOfMemory error in mirror Lambda function #7730

Open

nadove-ucsc force-pushed the issues/nadove-ucsc/7730-outofmemory-error-mirror-lambda-function branch from ffd9a85 to 776a383 Compare February 20, 2026 05:32

nadove-ucsc requested a review from achave11-ucsc February 20, 2026 05:50

nadove-ucsc assigned achave11-ucsc Feb 20, 2026

hannes-ucsc requested changes Feb 20, 2026

View reviewed changes

hannes-ucsc unassigned achave11-ucsc Feb 20, 2026

nadove-ucsc force-pushed the issues/nadove-ucsc/7730-outofmemory-error-mirror-lambda-function branch from 776a383 to a7bf558 Compare February 20, 2026 23:20

nadove-ucsc requested a review from hannes-ucsc February 20, 2026 23:59

nadove-ucsc assigned hannes-ucsc Feb 20, 2026

hannes-ucsc requested changes Feb 21, 2026

View reviewed changes

hannes-ucsc added the 0 reviews [process] Lead didn't request any changes label Feb 21, 2026

Fix: OutOfMemory error in mirror Lambda function (#7730)

20d44ef

nadove-ucsc force-pushed the issues/nadove-ucsc/7730-outofmemory-error-mirror-lambda-function branch from a7bf558 to a79fe4f Compare February 21, 2026 03:17

nadove-ucsc marked this pull request as ready for review February 21, 2026 03:18

nadove-ucsc added 3 commits February 20, 2026 19:22

fixup! Fix: OutOfMemory error in mirror Lambda function (#7730)

cae68ca

Add FIXME (#7798)

480a362

fixup! Add FIXME (#7798)

3fd9d21

nadove-ucsc force-pushed the issues/nadove-ucsc/7730-outofmemory-error-mirror-lambda-function branch from a79fe4f to 3fd9d21 Compare February 21, 2026 03:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Fix: OutOfMemory error in mirror Lambda function (#7730)#7795

Fix: OutOfMemory error in mirror Lambda function (#7730)#7795
nadove-ucsc wants to merge 4 commits intodevelopfrom
issues/nadove-ucsc/7730-outofmemory-error-mirror-lambda-function

nadove-ucsc commented Feb 20, 2026 •

edited

Loading

Uh oh!

coveralls commented Feb 20, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 20, 2026 •

edited

Loading

Uh oh!

hannes-ucsc Feb 20, 2026

Uh oh!

hannes-ucsc Feb 21, 2026

Uh oh!

hannes-ucsc Feb 21, 2026

Uh oh!

hannes-ucsc Feb 21, 2026

Uh oh!

hannes-ucsc Feb 21, 2026

Uh oh!

hannes-ucsc commented Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	management_resources: MutableJSON = {}
	runtime_version_configs: MutableJSON = {}

Comments

Conversation

nadove-ucsc commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Author

Author (partiality)

Author (reindex)

Author (API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator

Operator (deploy .shared and .gitlab components)

System administrator (post-deploy of .gitlab component)

Operator (deploy runner image)

Operator (sandbox build)

Operator (merge the branch)

Operator (main build)

Operator (reindex)

Operator (mirroring)

Operator

Shorthand for review comments

Uh oh!

coveralls commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hannes-ucsc Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc commented Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nadove-ucsc commented Feb 20, 2026 •

edited

Loading

Operator (deploy `.shared` and `.gitlab` components)

System administrator (post-deploy of `.gitlab` component)

coveralls commented Feb 20, 2026 •

edited

Loading

codecov bot commented Feb 20, 2026 •

edited

Loading