[DT-697] DUOS: B2C new MS login user display name is "unknown"

[cinyecai]

Addresses

https://broadworkbench.atlassian.net/browse/DT-697

Summary

If OAUTH2_CLAIM_name=unknown default the display name to the auth claim's email instead.

---

Have you read CONTRIBUTING.md lately? If not, do that first.

• Label PR with a Jira ticket number and include a link to the ticket
• Label PR with a security risk modifier [no, low, medium, high]
• PR describes scope of changes
• Get a minimum of one thumbs worth of review, preferably two if enough team members are available
• Get PO sign-off for all non-trivial UI or workflow changes
• Verify all tests go green
• Test this change deployed correctly and works on dev environment after deployment

[s-rubenstein]

Edit: I missed what Repo this was in - please ignore me

[pshapiro4broad]

Looks good to me. Are the unit tests for this class? If so, could this be tested there?

[cinyecai]

Could you make it name === "unknown" rather than name.equals("unknown")? I know we have the null check before, but in case it is undefined I want to make sure we are using the safer check.

Can you explain a bit more about the distinction, just for my understanding? I don't think "===" can be used in Java.

[s-rubenstein]

I misunderstood where this PR is - ignore me :|

[cinyecai]

Looks good to me. Are the unit tests for this class? If so, could this be tested there?

Yes, there are tests for this class, I made sure they all still pass. I can add some testing to test this change too!

[rjohanek]

with an additional unit test, I think this looks good!