-
Notifications
You must be signed in to change notification settings - Fork 2
DT-982: Refactor support ticket models #2437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/java/org/broadinstitute/consent/http/service/SupportRequestServiceTest.java
rushtong
commented
Dec 11, 2024
src/main/java/org/broadinstitute/consent/http/models/support/SupportRequest.java
Show resolved
Hide resolved
rushtong
commented
Dec 11, 2024
src/main/java/org/broadinstitute/consent/http/models/support/SupportTicket.java
Show resolved
Hide resolved
pshapiro4broad
approved these changes
Dec 11, 2024
Member
pshapiro4broad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, just a few comments
src/main/java/org/broadinstitute/consent/http/models/support/SupportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/consent/http/models/support/SupportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/consent/http/models/support/SupportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/consent/http/models/support/SupportRequest.java
Outdated
Show resolved
Hide resolved
rjohanek
reviewed
Dec 12, 2024
src/test/java/org/broadinstitute/consent/http/service/SupportRequestServiceTest.java
Show resolved
Hide resolved
rjohanek
reviewed
Dec 12, 2024
src/test/java/org/broadinstitute/consent/http/AbstractTest.java
Outdated
Show resolved
Hide resolved
rjohanek
approved these changes
Dec 12, 2024
Contributor
rjohanek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactor looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Partially addresses https://broadworkbench.atlassian.net/browse/DT-982
Summary
This PR refactors the model classes used for submitting Zendesk tickets. Future PRs will introduce more functionality such as adding API endpoints and real file uploads.
SupportTicket.yamlcorresponds to what is currently sent via the UI as an entity.SupportTicketResponse.yamlis the exact format Zendesk returns after a POST operation.Have you read CONTRIBUTING.md lately? If not, do that first.