Skip to content

DT-1763: Closeout Email Template #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rushtong merged 8 commits into from
Jun 5, 2025
Merged

DT-1763: Closeout Email Template #2547

rushtong merged 8 commits into from
Jun 5, 2025

Conversation

@rushtong
Copy link
Contributor

@rushtong rushtong commented Jun 4, 2025 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DT-1763

Summary

This creates an email template for sending a Closeout message to either Signing Officials or DAC members.

Template view:

Screenshot 2025-06-03 at 2 17 54 PM

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review June 4, 2025 11:23
@rushtong rushtong requested a review from a team as a code owner June 4, 2025 11:23
@rushtong rushtong requested review from fboulnois and snf2ye and removed request for a team June 4, 2025 11:23
rjohanek
rjohanek approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@rjohanek rjohanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

fboulnois
fboulnois approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

rushtong added 2 commits June 5, 2025 10:27
@rushtong
Merge branch 'develop' into gr-DT-1763-closeout-email-template
d78955c 
# Conflicts:
#	src/main/java/org/broadinstitute/consent/http/enumeration/EmailType.java
#	src/main/java/org/broadinstitute/consent/http/service/EmailService.java
@rushtong
feat: update id; merge fixup
5186f0f
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rushtong rushtong merged commit 82428f9 into develop Jun 5, 2025
16 checks passed
@rushtong rushtong deleted the gr-DT-1763-closeout-email-template branch June 5, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fboulnois fboulnois fboulnois approved these changes

@rjohanek rjohanek rjohanek approved these changes

@snf2ye snf2ye Awaiting requested review from snf2ye snf2ye is a code owner automatically assigned from DataBiosphere/dsp-data-team-eng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rushtong @fboulnois @rjohanek