Skip to content

[DT-3112] Add DELETE endpoint to Soft delete FileStorageObject#2864

Closed
kevinmarete wants to merge 3 commits intodevelopfrom
km-dt-3112-soft-delete-single-fso-entity
Closed

[DT-3112] Add DELETE endpoint to Soft delete FileStorageObject#2864
kevinmarete wants to merge 3 commits intodevelopfrom
km-dt-3112-soft-delete-single-fso-entity

Conversation

@kevinmarete
Copy link
Copy Markdown
Contributor

@kevinmarete kevinmarete commented Apr 15, 2026

Addresses

https://broadworkbench.atlassian.net/browse/DT-3112

Summary

This PR implements a soft delete endpoint for FileStorageObject (DELETE /api/{entity}/{entityId}/document/{id}), marking records as deleted without removing the underlying GCS blob. The change sets deleted, deleteUserId, and deleteDate fields while preserving audit history and enabling recovery.

Adds DAO support for soft deletion, enforces entity ownership and write access, and ensures idempotent behavior aligned with existing delete patterns. Also includes Swagger documentation and unit tests covering resource and DAO logic.

After

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@kevinmarete kevinmarete self-assigned this Apr 15, 2026
@kevinmarete kevinmarete changed the title Km dt 3112 soft delete single fso entity [DT-3112] Add DELETE endpoint to Soft delete FileStorageObject Apr 15, 2026
@sonarqubecloud
Copy link
Copy Markdown

@kevinmarete kevinmarete marked this pull request as ready for review April 15, 2026 19:04
@kevinmarete kevinmarete requested a review from a team as a code owner April 15, 2026 19:04
@kevinmarete kevinmarete requested review from Copilot, otchet-broad and rushtong and removed request for a team and Copilot April 15, 2026 19:05
@kevinmarete kevinmarete requested review from eweitz and removed request for otchet-broad April 15, 2026 20:27
@kevinmarete kevinmarete marked this pull request as draft April 16, 2026 14:48
@kevinmarete
Copy link
Copy Markdown
Contributor Author

To be implemented in this PR: #2867

@kevinmarete kevinmarete deleted the km-dt-3112-soft-delete-single-fso-entity branch April 16, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants